From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 30 Mar 2010 03:35:09 -0400 Subject: [U-Boot] net, kirkwood_egiga: init mac address before using network commands In-Reply-To: <4BB18E5F.6060705@denx.de> References: <4BB18E5F.6060705@denx.de> Message-ID: <201003300335.10436.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 30 March 2010 01:38:39 Heiko Schocher wrote: > diff --git a/drivers/net/kirkwood_egiga.c b/drivers/net/kirkwood_egiga.c > index 2ad7fea..e8b3777 100644 > --- a/drivers/net/kirkwood_egiga.c > +++ b/drivers/net/kirkwood_egiga.c > @@ -678,7 +678,7 @@ int kirkwood_egiga_initialize(bd_t * bis) > return -1; > } > > - while (!eth_getenv_enetaddr(s, dev->enetaddr)) { > + if (!eth_getenv_enetaddr(s, dev->enetaddr)) { this too is broken (not just your change, but also the existing code). please instead fix it to follow the documented MAC handling. the initialize function should seed dev->enetaddr with the eeprom value only while the init function should take care of programming dev->enetaddr into the hardware's MAC registers. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100330/083884aa/attachment.pgp