From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c Date: Tue, 30 Mar 2010 21:28:55 +0200 Message-ID: <20100330192855.GA24846@8bytes.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eduard - Gabriel Munteanu , aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Blue Swirl Return-path: Received: from 8bytes.org ([88.198.83.132]:43163 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562Ab0C3T24 (ORCPT ); Tue, 30 Mar 2010 15:28:56 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote: > On 3/30/10, Eduard - Gabriel Munteanu wrote: > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the > > AMD IOMMU, which could lead to confusion unless we rename the former. > > I was also thinking of renaming the file some time ago. The correct > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had > several IO-UNITs instead. All Sun4m machines had an IOMMU. > > But the qdev name of the device is still "iommu" and we can't change > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside > in amd_iommu.c? Keeping the plain name 'iommu' will likely cause confusion when more iommu implementations are added. It is better to rename it so that the name better describes what the file implements. So this change makes sense for me. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nwh7V-0001b5-Ek for qemu-devel@nongnu.org; Tue, 30 Mar 2010 15:29:01 -0400 Received: from [140.186.70.92] (port=38832 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nwh7U-0001Ze-6G for qemu-devel@nongnu.org; Tue, 30 Mar 2010 15:29:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nwh7R-00061R-Vc for qemu-devel@nongnu.org; Tue, 30 Mar 2010 15:28:59 -0400 Received: from 8bytes.org ([88.198.83.132]:33831) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwh7R-000616-Qd for qemu-devel@nongnu.org; Tue, 30 Mar 2010 15:28:57 -0400 Date: Tue, 30 Mar 2010 21:28:55 +0200 From: Joerg Roedel Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c Message-ID: <20100330192855.GA24846@8bytes.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, Eduard - Gabriel Munteanu On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote: > On 3/30/10, Eduard - Gabriel Munteanu wrote: > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the > > AMD IOMMU, which could lead to confusion unless we rename the former. > > I was also thinking of renaming the file some time ago. The correct > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had > several IO-UNITs instead. All Sun4m machines had an IOMMU. > > But the qdev name of the device is still "iommu" and we can't change > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside > in amd_iommu.c? Keeping the plain name 'iommu' will likely cause confusion when more iommu implementations are added. It is better to rename it so that the name better describes what the file implements. So this change makes sense for me. Joerg