From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduard - Gabriel Munteanu Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c Date: Tue, 30 Mar 2010 23:15:04 +0300 Message-ID: <20100330201504.GA7956@localhost> References: <20100330192855.GA24846@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Joerg Roedel , aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Blue Swirl Return-path: Received: from mail-bw0-f209.google.com ([209.85.218.209]:35804 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643Ab0C3UPJ (ORCPT ); Tue, 30 Mar 2010 16:15:09 -0400 Received: by bwz1 with SMTP id 1so4696793bwz.21 for ; Tue, 30 Mar 2010 13:15:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Mar 30, 2010 at 11:00:10PM +0300, Blue Swirl wrote: > On 3/30/10, Joerg Roedel wrote: > > On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote: > > > On 3/30/10, Eduard - Gabriel Munteanu wrote: > > > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the > > > > AMD IOMMU, which could lead to confusion unless we rename the former. > > > > > > I was also thinking of renaming the file some time ago. The correct > > > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a > > > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had > > > several IO-UNITs instead. All Sun4m machines had an IOMMU. > > > > > > But the qdev name of the device is still "iommu" and we can't change > > > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside > > > in amd_iommu.c? > > > > > > Keeping the plain name 'iommu' will likely cause confusion when more > > iommu implementations are added. It is better to rename it so that the > > name better describes what the file implements. So this change makes > > sense for me. > > I see. I'm OK then with "sun4m_iommu.c". Yes, I think it's enough to just change the filename, since multiple such devices aren't likely to conflict, in any configuration. Then "sun4m_iommu.c" it is. Will resubmit with the next patchset. Eduard From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwhqB-00047C-4h for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:15:11 -0400 Received: from [140.186.70.92] (port=50047 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nwhq9-00046Q-Jg for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:15:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nwhq8-0003Ca-CP for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:15:09 -0400 Received: from mail-bw0-f218.google.com ([209.85.218.218]:57683) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwhq8-0003CN-6Y for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:15:08 -0400 Received: by bwz10 with SMTP id 10so14806997bwz.2 for ; Tue, 30 Mar 2010 13:15:07 -0700 (PDT) Sender: Eduard - Gabriel Munteanu Date: Tue, 30 Mar 2010 23:15:04 +0300 From: Eduard - Gabriel Munteanu Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c Message-ID: <20100330201504.GA7956@localhost> References: <20100330192855.GA24846@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, Joerg Roedel , aliguori@us.ibm.com, kvm@vger.kernel.org, avi@redhat.com On Tue, Mar 30, 2010 at 11:00:10PM +0300, Blue Swirl wrote: > On 3/30/10, Joerg Roedel wrote: > > On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote: > > > On 3/30/10, Eduard - Gabriel Munteanu wrote: > > > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the > > > > AMD IOMMU, which could lead to confusion unless we rename the former. > > > > > > I was also thinking of renaming the file some time ago. The correct > > > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a > > > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had > > > several IO-UNITs instead. All Sun4m machines had an IOMMU. > > > > > > But the qdev name of the device is still "iommu" and we can't change > > > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside > > > in amd_iommu.c? > > > > > > Keeping the plain name 'iommu' will likely cause confusion when more > > iommu implementations are added. It is better to rename it so that the > > name better describes what the file implements. So this change makes > > sense for me. > > I see. I'm OK then with "sun4m_iommu.c". Yes, I think it's enough to just change the filename, since multiple such devices aren't likely to conflict, in any configuration. Then "sun4m_iommu.c" it is. Will resubmit with the next patchset. Eduard