From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758932Ab0DAUZX (ORCPT ); Thu, 1 Apr 2010 16:25:23 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:50328 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758916Ab0DAUZP (ORCPT ); Thu, 1 Apr 2010 16:25:15 -0400 From: "Rafael J. Wysocki" To: Alex Deucher Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) Date: Thu, 1 Apr 2010 22:28:06 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc3-rjw; KDE/4.3.5; x86_64; ; ) Cc: Clemens Ladisch , Linus Torvalds , Linux PCI , Greg KH , Linux Kernel Mailing List , Jesse Barnes , dri-devel@lists.sourceforge.net, stable@kernel.org, Dave Airlie References: <4BB43EE6.5040003@ladisch.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004012228.06938.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 01 April 2010, Alex Deucher wrote: > On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch wrote: > > Alex Deucher wrote: > >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki wrote: > >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote: > >>>> > PCI quirk: RS780/RS880: work around missing MSI initialization > >>>> > >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on my new test box > >>>> which happens to have a RS780. > > > > So it's better to disable MSI unconditionally. > > > > Rafael, can you check if MSI works for the HDMI audio device? > > (I'd guess it doesn't.) > > > >> I also have the attached patch queued in via Dave's tree to disable > >> MSI on all IGP chips for the time being. > > > > This disables MSI only for the graphics device. I'd prefer to have > > the quirk on its bridge so that MSI gets disabled for the HDMI audio > > device too, to avoid having to duplicate this quirk in the snd-hda-intel > > driver. > > > > ========== > > > > PCI quirk: RS780/RS880: disable MSI completely > > > > The missing initialization of the nb_cntl.strap_msi_enable does not seem > > to be the only problem that prevents MSI, so that quirk is not > > sufficient to enable MSI on all machines. To be safe, unconditionally > > disable MSI for the internal graphics and HDMI audio on these chipsets. > > > > Signed-off-by: Clemens Ladisch > > Works fine here. > > Tested-by: Alex Deucher Unfortunately it doesn't work for me without the if ((rdev->family >= CHIP_RV380) && (!(rdev->flags & RADEON_IS_IGP))) radeon quirk. Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [Regression, post-rc2] Commit a5ee4eb7541 breaks OpenGL on RS780 (was: Re: Linux 2.6.34-rc3) Date: Thu, 1 Apr 2010 22:28:06 +0200 Message-ID: <201004012228.06938.rjw@sisk.pl> References: <4BB43EE6.5040003@ladisch.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Alex Deucher Cc: Linux PCI , Greg KH , Clemens Ladisch , Linux Kernel Mailing List , Jesse Barnes , dri-devel@lists.sourceforge.net, Linus Torvalds , stable@kernel.org List-Id: dri-devel@lists.freedesktop.org On Thursday 01 April 2010, Alex Deucher wrote: > On Thu, Apr 1, 2010 at 2:36 AM, Clemens Ladisch wrote: > > Alex Deucher wrote: > >> On Wed, Mar 31, 2010 at 9:13 PM, Rafael J. Wysocki wrote: > >>> On Tuesday 30 March 2010, Rafael J. Wysocki wrote: > >>>> > PCI quirk: RS780/RS880: work around missing MSI initialization > >>>> > >>>> This one (commit a5ee4eb7541) broke OpenGL acceleration on my new test box > >>>> which happens to have a RS780. > > > > So it's better to disable MSI unconditionally. > > > > Rafael, can you check if MSI works for the HDMI audio device? > > (I'd guess it doesn't.) > > > >> I also have the attached patch queued in via Dave's tree to disable > >> MSI on all IGP chips for the time being. > > > > This disables MSI only for the graphics device. I'd prefer to have > > the quirk on its bridge so that MSI gets disabled for the HDMI audio > > device too, to avoid having to duplicate this quirk in the snd-hda-intel > > driver. > > > > ========== > > > > PCI quirk: RS780/RS880: disable MSI completely > > > > The missing initialization of the nb_cntl.strap_msi_enable does not seem > > to be the only problem that prevents MSI, so that quirk is not > > sufficient to enable MSI on all machines. To be safe, unconditionally > > disable MSI for the internal graphics and HDMI audio on these chipsets. > > > > Signed-off-by: Clemens Ladisch > > Works fine here. > > Tested-by: Alex Deucher Unfortunately it doesn't work for me without the if ((rdev->family >= CHIP_RV380) && (!(rdev->flags & RADEON_IS_IGP))) radeon quirk. Thanks, Rafael ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --