All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: waldi@debian.org, Carsten Otte <carsteno@de.ibm.com>,
	qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 4/6] Always notify consumers of char devices if they're open
Date: Mon, 5 Apr 2010 09:13:38 +0530	[thread overview]
Message-ID: <20100405034338.GB7100@amit-x200.redhat.com> (raw)
In-Reply-To: <1270140161-17216-5-git-send-email-agraf@suse.de>

On (Thu) Apr 01 2010 [18:42:39], Alexander Graf wrote:
> When using virtio-console on s390, the input doesn't work.
> 
> The root of the problem is rather simple. What happens is the following:
> 
>  1) create character device for stdio
>  2) char device is done creating, sends OPENED event
>  3) virtio-console adds handlers
>  4) no event comes because the char device is open already
>  5) virtio-console doesn't accept input because it didn't
>     receive an OPENED event
> 
> To make that sure virtio-console gets notified that the character device
> is open even when it's been open from the beginning, this patch introduces
> a variable that keeps track of the opened state. If the device is open when
> the event handlers get installed, we just notify the handler.
> 
> This fixes input with virtio-console on s390.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Acked-by: Amit Shah <amit.shah@redhat.com>

		Amit

  reply	other threads:[~2010-04-05  3:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 16:42 [Qemu-devel] [PATCH 0/6] S390 April patch round Alexander Graf
2010-04-01 16:42 ` [Qemu-devel] [PATCH 1/6] S390: Add stub for cpu_get_phys_page_debug Alexander Graf
2010-04-01 16:42 ` [Qemu-devel] [PATCH 2/6] S390: Tell user why VM creation failed Alexander Graf
2010-04-01 16:42 ` [Qemu-devel] [PATCH 3/6] Make char muxer more robust wrt small FIFOs Alexander Graf
2010-04-05  3:40   ` Amit Shah
2010-04-07 14:32     ` Alexander Graf
2010-04-07 14:43       ` Amit Shah
2010-04-01 16:42 ` [Qemu-devel] [PATCH 4/6] Always notify consumers of char devices if they're open Alexander Graf
2010-04-05  3:43   ` Amit Shah [this message]
2010-04-09 20:09   ` Aurelien Jarno
2010-04-01 16:42 ` [Qemu-devel] [PATCH 5/6] [S390] Implement virtio reset Alexander Graf
2010-04-09 20:09   ` Aurelien Jarno
2010-04-01 16:42 ` [Qemu-devel] [PATCH 6/6] [S390] Add firmware code Alexander Graf
2010-04-01 21:18   ` [Qemu-devel] " Bastian Blank
2010-04-01 22:10     ` Alexander Graf
2010-04-09 20:17   ` [Qemu-devel] " Aurelien Jarno
2010-04-09 23:29     ` Alexander Graf
2010-04-10  0:00       ` Aurelien Jarno
2010-04-10  9:22         ` Alexander Graf
2010-04-10 15:03           ` Aurelien Jarno
2010-04-12  8:43     ` Carsten Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100405034338.GB7100@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=carsteno@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=waldi@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.