Re: [PATCH 7/8] USB: testusb: imported David Brownell's USB testing application

From: Greg KH <greg@kroah.com>
To: Heikki Krogerus <ext-heikki.krogerus@nokia.com>
Cc: ext Michal Nazarewicz <m.nazarewicz@samsung.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Peter Korsgaard <jacmet@sunsite.dk>,
	Rupesh Gujare <rupeshgujare@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 7/8] USB: testusb: imported David Brownell's USB testing application
Date: Wed, 7 Apr 2010 23:18:46 -0700	[thread overview]
Message-ID: <20100408061846.GA29184@kroah.com> (raw)
In-Reply-To: <20100408061000.GA7606@esdhcp042221.research.nokia.com>

On Thu, Apr 08, 2010 at 09:10:00AM +0300, Heikki Krogerus wrote:
> Hi,
> 
> If this is going into kernel then..
> 
> On Wed, Apr 07, 2010 at 03:41:34PM +0200, ext Michal Nazarewicz wrote:
> 
> ...
> 
> > +       if ((c = open ("/proc/bus/usb/devices", O_RDONLY)) < 0) {
> > +               fputs ("usbfs files are missing\n", stderr);
> > +               return -1;
> > +       }
> 
> Is this needed?
> 
> > +
> > +       /* collect and list the test devices */
> > +       if (ftw ("/proc/bus/usb", find_testdev, 3) != 0) {
> 
> How about "/dev/bus/usb" instead? Some distributions do not enable
> sysfs in their default kernels anymore.

You mean 'usbfs' not 'sysfs', right?

And yes, this probably should be fixed, patches are always welcome :)

thanks,

greg k-h