All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Rast <trast@student.ethz.ch>, git@vger.kernel.org
Subject: Re: [PATCH] log: respect log.shownotes variable
Date: Thu, 8 Apr 2010 03:05:26 -0400	[thread overview]
Message-ID: <20100408070526.GH30473@coredump.intra.peff.net> (raw)
In-Reply-To: <7vljczapzt.fsf@alter.siamese.dyndns.org>

On Wed, Apr 07, 2010 at 02:53:42PM -0700, Junio C Hamano wrote:

> My gut feeling is that people who do have notes in the default namespace
> (or the ones in notes.displayRef) do want to see them _all the time_.
> Otherwise they'd put such notes in namespaces that are not shown by
> default, and view them on demand, no?

I dunno. I don't have any notes I've written, so I just stuck Thomas' in
refs/notes/commit. In retrospect, that was probably dumb, because it
conflicts with any notes I would write.

> But then there is a bigger question: what kind of notes would you want to
> always see as part of "git log" output?  My answer to that question for my
> personal workflow (both dayjob and here) so far has been "none", and that
> is exactly the reason why my "applied from this message" notes live in
> notes/am namespace and I have nothing in the default notes namespace.

Yeah, thinking on it more, that is much better. I now have:

  [remote "trast"]
	  url = git://repo.or.cz/git/trast.git
	  fetch = +refs/heads/notes/*:refs/notes/am/*

which makes more sense (and I was happy to see he has kept updating
them. My copy was quite stale).

So let's ignore log.shownotes for now, and encourage people to manage
their notes better. When we see more how people are using notes, we may
want it, but let's wait until then.

-Peff

  parent reply	other threads:[~2010-04-08  7:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07 20:45 [PATCH] log: respect log.shownotes variable Jeff King
2010-04-07 21:53 ` Junio C Hamano
2010-04-08  2:01   ` Michael J Gruber
2010-04-08  7:07     ` Jeff King
2010-04-08  7:05   ` Jeff King [this message]
2010-04-08 16:12 ` Thomas Rast
2010-04-08 16:55   ` Junio C Hamano
2010-04-08 19:16   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100408070526.GH30473@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.