From: Liang Li <liang.li@windriver.com> To: Yong Zhang <yong.zhang@windriver.com> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Kernel Testers List <kernel-testers@vger.kernel.org>, Maciej Rutecki <maciej.rutecki@gmail.com>, Amit Shah <shahamit@gmail.com> Subject: Re: [Bug #15615] NULL pointer deref in task_is_waking Date: Thu, 8 Apr 2010 16:20:00 +0800 [thread overview] Message-ID: <20100408082000.GA10399@localhost> (raw) In-Reply-To: <20100408075003.GC12905@windriver.com> On Thu, Apr 08, 2010 at 03:50:03PM +0800, Yong Zhang wrote: > On Thu, Apr 08, 2010 at 03:16:17PM +0800, Liang Li wrote: > > On Wed, Apr 07, 2010 at 11:13:48PM +0200, Rafael J. Wysocki wrote: > > > This message has been generated automatically as a part of a summary report > > > of recent regressions. > > > > > > The following bug entry is on the current list of known regressions > > > from 2.6.33. Please verify if it still should be listed and let the tracking team > > > know (either way). > > > > The bug still there. I just met it. And seems its quite simple to get it > > fixed. > > > > diff --git a/kernel/sched.c b/kernel/sched.c > > index a3dff1f..2df1a76 100644 > > --- a/kernel/sched.c > > +++ b/kernel/sched.c > > @@ -913,7 +913,7 @@ static inline void finish_lock_switch(struct rq *rq, struct task_struct *prev) > > */ > > static inline int task_is_waking(struct task_struct *p) > > { > > - return unlikely((p->state == TASK_WAKING) && !(p->flags & PF_STARTING)); > > + return unlikely(p && (p->state == TASK_WAKING) && !(p->flags & PF_STARTING)); > > } Seems what I saw was different from this bug. So it is clear that this one line change does not relate to this bug. Sorry for confusion. > > Oh, NO. This is wrong. It will introduce other bugs. > The right direction is showed in the bug entry. Thanks, -Liang Li > > Thanks, > Yong > > > > > /* > > > > But seems commitid 0017d735092844118bef006696a750a0e4ef6ebd in tip tree > > also touched task_is_waking. So the patch for tip tree should be: > > > > diff --git a/kernel/sched.c b/kernel/sched.c > > index 3acf694..d259641 100644 > > --- a/kernel/sched.c > > +++ b/kernel/sched.c > > @@ -920,7 +920,7 @@ static inline void finish_lock_switch(struct rq *rq, struct task_struct *prev) > > */ > > static inline int task_is_waking(struct task_struct *p) > > { > > - return unlikely(p->state == TASK_WAKING); > > + return unlikely(p && p->state == TASK_WAKING); > > } > > > > /* > > > > Regards, > > -Liang Li > > > > > > > > > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15615 > > > Subject : NULL pointer deref in task_is_waking > > > Submitter : Amit Shah <shahamit@gmail.com> > > > Date : 2010-03-23 04:04 (16 days old) > > > > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Please read the FAQ at http://www.tux.org/lkml/ > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2010-04-08 8:21 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-07 21:08 2.6.34-rc3-git6: Reported regressions from 2.6.33 Rafael J. Wysocki 2010-04-07 21:08 ` Rafael J. Wysocki 2010-04-07 21:08 ` [Bug #15480] [regression] Fails to boot properly unless given pci=nocrs Rafael J. Wysocki 2010-04-07 22:02 ` Bjorn Helgaas 2010-04-08 19:54 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15553] Screen backlight doesn't come back on after lid was closed (GM45) Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15505] No more b43 wireless interface since 2.6.34-rc1 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15518] CONFIG_NO_BOOTMEM=y breaks boot on 32bit Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15551] WARNING: at net/mac80211/work.c:811 ieee80211_work_work+0x7f/0xde8 [mac80211]() Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15600] CONFIG_NO_BOOTMEM woes, 2.6.34-rc1 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15603] lockdep warning at boot time when determining whether to resume Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15590] 2.6.34-rc1: regression: ^Z no longer stops sound Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15601] [BUG] SLOB breaks Crypto Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15615] NULL pointer deref in task_is_waking Rafael J. Wysocki 2010-04-08 7:16 ` Liang Li 2010-04-08 7:50 ` Yong Zhang 2010-04-08 8:20 ` Liang Li [this message] 2010-04-07 21:13 ` [Bug #15611] Failure with the 2.6.34-rc1 kernel Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15610] fsck leads to swapper - BUG: unable to handle kernel NULL pointer dereference & panic Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15619] Regression - Linux 2.6.34-rc1 - i915 - Render error detected Rafael J. Wysocki 2010-04-08 7:32 ` Fabio Comolli 2010-04-08 20:00 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15625] BUG: 2.6.34-rc1, RIP is (null) Rafael J. Wysocki 2010-04-12 3:00 ` Randy Dunlap 2010-04-12 23:09 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15624] [BUG] percpu misaligned allocation Rafael J. Wysocki 2010-04-07 21:59 ` Frederic Weisbecker 2010-04-08 20:02 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15664] Graphics hang and kernel backtrace when starting Azureus with Compiz enabled Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15659] [Regresion] [2.6.34-rc1] [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15655] corrupt ext3 fs and partial freeze Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15661] PROBLEM: crash on halt with 2.6.34-0.16.rc2.git0.fc14.x86_64 Rafael J. Wysocki 2010-04-08 2:29 ` Yong Zhang 2010-04-08 20:04 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15673] 2.6.34-rc2: "ima_dec_counts: open/free imbalance"? Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15669] INFO: suspicious rcu_dereference_check() Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15671] intel graphic card hanging (Hangcheck timer elapsed... GPU hung) Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15668] start_kernel(): bug: interrupts were enabled early Rafael J. Wysocki 2010-04-07 22:32 ` H. Peter Anvin 2010-04-08 20:06 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15672] KVM bug, git bisected Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15711] 2.6.34-rc3, BUG at mm/slab.c:2989 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15704] [r8169] WARNING: at net/sched/sch_generic.c Rafael J. Wysocki 2010-04-14 10:12 ` Sergey Senozhatsky 2010-04-15 17:16 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15712] [regression] 2.6.34-rc1 to -rc3 on zaurus: no longer boots Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15674] [2.6.34-rc2 NFS4 oops] open error path failure Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15718] File corruption regression on NFS related to commit 1f36f774 Rafael J. Wysocki 2010-04-08 11:56 ` Boaz Harrosh 2010-04-08 20:10 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15716] ata2: lost interrupt with kernel 2.6.34-rc1 Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15717] bluetooth oops Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15715] vmscan: underflow for get_scan_ratio Rafael J. Wysocki 2010-04-07 22:05 ` Linus Torvalds 2010-04-08 20:09 ` Rafael J. Wysocki 2010-04-07 21:13 ` [Bug #15719] virtio_net causing kernel BUG when running under VirtualBox Rafael J. Wysocki 2010-04-12 8:39 ` Thomas Müller 2010-04-12 9:28 ` David Miller 2010-04-12 9:50 ` Thomas Müller 2010-04-13 5:01 ` David Miller 2010-04-07 21:53 ` 2.6.34-rc3-git6: Reported regressions from 2.6.33 John W. Linville 2010-04-07 21:53 ` John W. Linville 2010-04-07 22:04 ` Linus Torvalds 2010-04-07 22:04 ` Linus Torvalds 2010-04-07 22:19 ` Al Viro 2010-04-07 22:19 ` Al Viro 2010-04-07 22:22 ` Linus Torvalds 2010-04-07 22:22 ` Linus Torvalds 2010-04-07 22:22 ` Linus Torvalds 2010-04-07 23:06 ` Al Viro 2010-04-07 23:06 ` Al Viro 2010-04-07 23:06 ` Al Viro 2010-04-07 22:19 ` Al Viro 2010-04-08 20:24 ` Rafael J. Wysocki 2010-04-08 20:24 ` Rafael J. Wysocki 2010-04-08 20:24 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100408082000.GA10399@localhost \ --to=liang.li@windriver.com \ --cc=kernel-testers@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maciej.rutecki@gmail.com \ --cc=rjw@sisk.pl \ --cc=shahamit@gmail.com \ --cc=yong.zhang@windriver.com \ --subject='Re: [Bug #15615] NULL pointer deref in task_is_waking' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.