All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Divyesh Shah <dpshah@google.com>,
	vgoyal@redhat.com, linux-kernel@vger.kernel.org,
	nauman@google.com, ctalbott@google.com
Subject: Re: [PATCH][v3.1] blkio: Add io controller stats like
Date: Thu, 8 Apr 2010 14:46:30 +0200	[thread overview]
Message-ID: <20100408124629.GN10103@kernel.dk> (raw)
In-Reply-To: <4BBD3DB9.8090006@cn.fujitsu.com>

On Thu, Apr 08 2010, Gui Jianfeng wrote:
> Divyesh Shah wrote:
> > - io_service_time (the total time between request dispatch and completion for
> >   all IOs in the cgroup)
> > - io_wait_time (the total time spent waiting by all IOs in this cgroup in the IO
> >   scheduler queues before getting serviced)
> > - io_serviced (number of IOs serviced from this blkio_group)
> > - io_service_bytes (Number of bytes served for this cgroup)
> > 
> > These stats are accumulated per operation type helping us to distinguish between
> > read and write, and sync and async IO. This patch does not increment any of
> > these stats.
> > 
> > Changelog from v3:
> > o renamed blkiocg_reset_write to blkiocg_reset_stats
> > o more clarification in the documentation on io_service_time and io_wait_time.
> > 
> > Signed-off-by: Divyesh Shah<dpshah@google.com>
> 
> Hi Divyesh,
> 
> Jens has already applied previous patchset to for-2.6.35 branch, so v3 patchset
> and this patch have conflicts with for-2.6.35 branch. I think it's better to make
> new patch on top of for-2.6.35.

Thanks, was just about to ask. Please make an updated patch against what
I already have, so I don't have to revert/rebase to make this work.

-- 
Jens Axboe


  reply	other threads:[~2010-04-08 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-06 23:28 [PATCH][v3.1] blkio: Add io controller stats like Divyesh Shah
2010-04-07 13:27 ` Vivek Goyal
2010-04-08  2:21 ` Gui Jianfeng
2010-04-08 12:46   ` Jens Axboe [this message]
2010-04-08 16:41     ` Divyesh Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100408124629.GN10103@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=ctalbott@google.com \
    --cc=dpshah@google.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nauman@google.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.