[PATCH] i915: do not read uninitialized ->dev_private

[PATCH] i915: do not read uninitialized ->dev_private

[Luca Tettamanti]

->dev_private at that point is NULL and is initialied only a few lines
later.

Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
---
I'm beginnig to dive into DRM&KMS, that assignment really confused me :P

 drivers/gpu/drm/i915/i915_dma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index a9f8589..648670d 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -1578,7 +1578,7 @@ static void i915_get_mem_freq(struct drm_device *dev)
  */
 int i915_driver_load(struct drm_device *dev, unsigned long flags)
 {
-	struct drm_i915_private *dev_priv = dev->dev_private;
+	struct drm_i915_private *dev_priv;
 	resource_size_t base, size;
 	int ret = 0, mmio_bar;
 	uint32_t agp_size, prealloc_size, prealloc_start;

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

Re: [PATCH] i915: do not read uninitialized ->dev_private

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 329 bytes --]

On Thu, 8 Apr 2010 21:41:59 +0200, Luca Tettamanti <kronos.it@gmail.com> wrote:
> ->dev_private at that point is NULL and is initialied only a few lines
> later.
> 
> Signed-off-by: Luca Tettamanti <kronos.it@gmail.com>
> ---
> I'm beginnig to dive into DRM&KMS, that assignment really confused me :P

Applied.  Thanks!

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx