From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Brook Subject: Re: [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory Date: Fri, 9 Apr 2010 13:00:57 +0100 Message-ID: <201004091300.57740.paul@codesourcery.com> References: <20100407040129.20274.44284.stgit@angua> <20100407041002.20274.51604.stgit@angua> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100407041002.20274.51604.stgit@angua> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org List-Id: devicetree@vger.kernel.org > If a small 'seed' dtb file is loaded into qemu and then heavily modified > (say for runtime population of all the device nodes), then 2x the dtb > size turns out not to be very much. > > This patch changes the device tree loading code to add a fixed 8k of > additional space to the dtb buffer. In that case you almost certainly want double+8k. Or have the calleee tell you how much they're expecting to grow the tree. Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0Ctd-00072y-RJ for qemu-devel@nongnu.org; Fri, 09 Apr 2010 08:01:13 -0400 Received: from [140.186.70.92] (port=34070 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0Ctb-00072B-PW for qemu-devel@nongnu.org; Fri, 09 Apr 2010 08:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0CtY-0006aQ-AC for qemu-devel@nongnu.org; Fri, 09 Apr 2010 08:01:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:37349) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0CtX-0006Tw-D7 for qemu-devel@nongnu.org; Fri, 09 Apr 2010 08:01:07 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1O0CtW-0004TL-9o for qemu-devel@nongnu.org; Fri, 09 Apr 2010 08:01:07 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory Date: Fri, 9 Apr 2010 13:00:57 +0100 References: <20100407040129.20274.44284.stgit@angua> <20100407041002.20274.51604.stgit@angua> In-Reply-To: <20100407041002.20274.51604.stgit@angua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201004091300.57740.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Grant Likely , devicetree-discuss@lists.ozlabs.org, jeremy.kerr@canonical.com > If a small 'seed' dtb file is loaded into qemu and then heavily modified > (say for runtime population of all the device nodes), then 2x the dtb > size turns out not to be very much. > > This patch changes the device tree loading code to add a fixed 8k of > additional space to the dtb buffer. In that case you almost certainly want double+8k. Or have the calleee tell you how much they're expecting to grow the tree. Paul