All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Fix format specifiers for fpu_fprintf
Date: Fri, 9 Apr 2010 21:54:42 +0200	[thread overview]
Message-ID: <20100409195442.GH21042@volta.aurel32.net> (raw)
In-Reply-To: <1270155914-21047-1-git-send-email-weil@mail.berlios.de>

On Thu, Apr 01, 2010 at 11:05:14PM +0200, Stefan Weil wrote:
> In the previous patch which introduced fprintf_function to
> allow parameter checking by gcc some compiler warnings
> remained unfixed.
> 
> These warnings are fixed here.

Thanks applied.

> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  target-mips/translate.c |   34 ++++++++++++++++++++--------------
>  1 files changed, 20 insertions(+), 14 deletions(-)
> 
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 02367e4..61f8d72 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -9563,20 +9563,26 @@ static void fpu_dump_state(CPUState *env, FILE *f,
>      int i;
>      int is_fpu64 = !!(env->hflags & MIPS_HFLAG_F64);
>  
> -#define printfpr(fp)                                                        \
> -    do {                                                                    \
> -        if (is_fpu64)                                                       \
> -            fpu_fprintf(f, "w:%08x d:%016lx fd:%13g fs:%13g psu: %13g\n",   \
> -                        (fp)->w[FP_ENDIAN_IDX], (fp)->d, (fp)->fd,          \
> -                        (fp)->fs[FP_ENDIAN_IDX], (fp)->fs[!FP_ENDIAN_IDX]); \
> -        else {                                                              \
> -            fpr_t tmp;                                                      \
> -            tmp.w[FP_ENDIAN_IDX] = (fp)->w[FP_ENDIAN_IDX];                  \
> -            tmp.w[!FP_ENDIAN_IDX] = ((fp) + 1)->w[FP_ENDIAN_IDX];           \
> -            fpu_fprintf(f, "w:%08x d:%016lx fd:%13g fs:%13g psu:%13g\n",    \
> -                        tmp.w[FP_ENDIAN_IDX], tmp.d, tmp.fd,                \
> -                        tmp.fs[FP_ENDIAN_IDX], tmp.fs[!FP_ENDIAN_IDX]);     \
> -        }                                                                   \
> +#define printfpr(fp)                                                    \
> +    do {                                                                \
> +        if (is_fpu64)                                                   \
> +            fpu_fprintf(f, "w:%08x d:%016" PRIx64                       \
> +                        " fd:%13g fs:%13g psu: %13g\n",                 \
> +                        (fp)->w[FP_ENDIAN_IDX], (fp)->d,                \
> +                        (double)(fp)->fd,                               \
> +                        (double)(fp)->fs[FP_ENDIAN_IDX],                \
> +                        (double)(fp)->fs[!FP_ENDIAN_IDX]);              \
> +        else {                                                          \
> +            fpr_t tmp;                                                  \
> +            tmp.w[FP_ENDIAN_IDX] = (fp)->w[FP_ENDIAN_IDX];              \
> +            tmp.w[!FP_ENDIAN_IDX] = ((fp) + 1)->w[FP_ENDIAN_IDX];       \
> +            fpu_fprintf(f, "w:%08x d:%016" PRIx64                       \
> +                        " fd:%13g fs:%13g psu:%13g\n",                  \
> +                        tmp.w[FP_ENDIAN_IDX], tmp.d,                    \
> +                        (double)tmp.fd,                                 \
> +                        (double)tmp.fs[FP_ENDIAN_IDX],                  \
> +                        (double)tmp.fs[!FP_ENDIAN_IDX]);                \
> +        }                                                               \
>      } while(0)
>  
>  
> -- 
> 1.7.0
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

  reply	other threads:[~2010-04-09 21:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 19:16 [Qemu-devel] Check format specifiers for fprintf like function pointers Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 01/14] Add new data type " Stefan Weil
2010-04-08 19:29   ` Aurelien Jarno
2010-04-09 11:20     ` Stefan Weil
2010-07-01  9:08       ` Stefan Weil
2010-07-01 23:08         ` Aurelien Jarno
2010-07-02 15:37       ` [Qemu-devel] " Paolo Bonzini
2010-07-02 16:17         ` [Qemu-devel] [RFC] env stored in segment register for i386 Richard Henderson
2010-07-03  7:32         ` [Qemu-devel] Re: [PATCH 01/14] Add new data type for fprintf like function pointers Blue Swirl
2010-03-29 19:16 ` [Qemu-devel] [PATCH 02/14] Use fprint_function and fix wrong format specifiers Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 03/14] target-alpha: Use fprintf_function Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 04/14] target-arm: " Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 05/14] target-cris: " Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 06/14] target-i386: Use fprintf_function and fix dump of DR registers Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 07/14] target-m68k: Use fprintf_function Stefan Weil
2010-03-29 19:16 ` [Qemu-devel] [PATCH 08/14] target-microblaze: " Stefan Weil
2010-03-29 19:17 ` [Qemu-devel] [PATCH 09/14] target-mips: Use fprintf_function and fix wrong format specifiers Stefan Weil
2010-04-01 21:05   ` [Qemu-devel] [PATCH] target-mips: Fix format specifiers for fpu_fprintf Stefan Weil
2010-04-09 19:54     ` Aurelien Jarno [this message]
2010-03-29 19:17 ` [Qemu-devel] [PATCH 10/14] target-ppc: Use fprintf_function and fix wrong format specifiers Stefan Weil
2010-03-29 19:17 ` [Qemu-devel] [PATCH 11/14] target-sh4: Use fprintf_function Stefan Weil
2010-03-29 19:17 ` [Qemu-devel] [PATCH 12/14] target-sparc: " Stefan Weil
2010-03-29 19:17 ` [Qemu-devel] [PATCH 13/14] target-s390: " Stefan Weil
2010-03-29 19:17 ` [Qemu-devel] [PATCH 14/14] tcg: " Stefan Weil
2010-03-29 19:27 ` [Qemu-devel] Check format specifiers for fprintf like function pointers Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100409195442.GH21042@volta.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.