All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitri Belimov <d.belimov@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] Fix default state Beholder H6 tuner.
Date: Mon, 12 Apr 2010 14:50:34 +1000	[thread overview]
Message-ID: <20100412145034.6002ebd8@glory.loctelecom.ru> (raw)
In-Reply-To: <4BBE9CB7.5090206@infradead.org>

Hi Mauro

> Em 01-04-2010 01:33, Dmitri Belimov escreveu:
> > Hi Hermann
> > 
> >> Hi Dimitry,
> >>
> >> Am Mittwoch, den 31.03.2010, 13:14 +1000 schrieb Dmitri Belimov:
> >>> Hi Hermann
> >>>
> >>>> Hi,
> >>>>
> >>>> Am Dienstag, den 30.03.2010, 16:02 +1000 schrieb Dmitri Belimov:
> >>>>> Hi
> >>>>>
> >>>>> The hybrid tuner FMD1216MEX_MK3 after cold start has disabled
> >>>>> IF. This tuner has internal I2C switch. This switch switch I2C
> >>>>> bus between DVB-T and IF part. Default state is DVB-T. When
> >>>>> module saa7134 is load it can't find IF tda9887 and disable
> >>>>> analog TV mode.
> >>>>>
> >>>>> This patch set internal I2C switch of the tuner to IF by send
> >>>>> special value to the tuner as for receive analog TV from low
> >>>>> band. It can be usefule for other cards.
> >>>>>
> >>>>> I didn't set configure a tuner by a tuner model because this
> >>>>> tuner can has different I2C address. May be we can do it later
> >>>>> after discuss for more robust support a tuners.
> >>>>
> >>>> just as a reminder. It is the same for the FMD1216ME hybrid MK3.
> >>>> After every boot, analog mode fails with missing tda9887.
> >>>>
> >>>> Currently, after tuner modules are not independent anymore, one
> >>>> has to reload the saa7134 driver once.
> >>>>
> >>>> Relevant code in tuner.core.c.
> >>>>
> >>>> 	case TUNER_PHILIPS_FMD1216ME_MK3:
> >>>> 		buffer[0] = 0x0b;
> >>>> 		buffer[1] = 0xdc;
> >>>> 		buffer[2] = 0x9c;
> >>>> 		buffer[3] = 0x60;
> >>>> 		i2c_master_send(c, buffer, 4);
> >>>> 		mdelay(1);
> >>>> 		buffer[2] = 0x86;
> >>>> 		buffer[3] = 0x54;
> >>>> 		i2c_master_send(c, buffer, 4);
> >>>> 		if (!dvb_attach(simple_tuner_attach, &t->fe,
> >>>> 				t->i2c->adapter, t->i2c->addr,
> >>>> t->type)) goto attach_failed;
> >>>> 		break;
> >>>
> >>> That is good. I'll try add case TUNER_PHILIPS_FMD1216MEX_MK3 here
> >>> and test. This is much better.
> >>
> >> it wont work for any what I can tell.
> >>
> >> We were forced into such an universal looking solution, but it was
> >> broken only a short time later.
> >>
> >> I for sure don't say that this time, late 2005, it was in anyway
> >> perfect, too much random on module load orders and also duplicate
> >> address stuff around meanwhile.
> >>
> >> But, however, it seems to be blocked for a global attempt within
> >> the current schemes too.
> > 
> > Yes. Not worked. My patch is good for our customers right now. But
> > when this subsystem is ready we can switch to use it.
> > 
> > With my best regards, Dmitry.
> > 
> 
> I'll apply the patch for now, but the better is to fix the
> TUNER_PHILIPS_FMD1216MEX_MK3.
> 
> Dmitri, could you please try to fix it with a more generic solution?

Ok. I'll do it later.

With my best regards, Dmitry.

> 
> Thanks,
> Mauro

      reply	other threads:[~2010-04-12  4:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30  6:02 [PATCH] Fix default state Beholder H6 tuner Dmitri Belimov
2010-03-30  9:54 ` hermann pitton
2010-03-31  3:14   ` Dmitri Belimov
2010-04-01  0:31     ` hermann pitton
2010-04-01  4:33       ` Dmitri Belimov
2010-04-09  3:19         ` Mauro Carvalho Chehab
2010-04-12  4:50           ` Dmitri Belimov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100412145034.6002ebd8@glory.loctelecom.ru \
    --to=d.belimov@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.