From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452Ab0DSSFe (ORCPT ); Mon, 19 Apr 2010 14:05:34 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:48172 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab0DSSFc (ORCPT ); Mon, 19 Apr 2010 14:05:32 -0400 Date: Mon, 19 Apr 2010 20:05:20 +0200 From: Ingo Molnar To: David Miller Cc: tilman@imap.cc, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: tip: origin tree build failure, [patch] fix isdn/gigaset build failure Message-ID: <20100419180520.GA9244@elte.hu> References: <20100419.003857.260094283.davem@davemloft.net> <20100419172731.GA4358@elte.hu> <20100419.103304.35342954.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100419.103304.35342954.davem@davemloft.net> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * David Miller wrote: > From: Ingo Molnar > Date: Mon, 19 Apr 2010 19:27:31 +0200 > > > Introduced by commit b91ecb00 that got pushed out today. That change removed > > an implicit sched.h inclusion that came in via slab.h. > > > > The patch below fixes it by adding the sched.h dependency. > > Thanks Ingo, Linus please apply: > > Acked-by: David S. Miller Note, i just found that my patch is not enough as we fail the build elsewhere as well: drivers/isdn/gigaset/proc.c:52: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/proc.c:52: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/proc.c:52: error: for each function it appears in.) drivers/isdn/gigaset/proc.c:52: error: implicit declaration of function 'schedule' drivers/isdn/gigaset/interface.c:49: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/interface.c:49: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/interface.c:49: error: for each function it appears in.) drivers/isdn/gigaset/interface.c:49: error: implicit declaration of function 'schedule' drivers/isdn/gigaset/interface.c:83: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/isdn/gigaset/ev-layer.c:981: error: 'TASK_NORMAL' undeclared (first use in this function) drivers/isdn/gigaset/ev-layer.c:981: error: (Each undeclared identifier is reported only once drivers/isdn/gigaset/ev-layer.c:981: error: for each function it appears in.) drivers/isdn/gigaset/ev-layer.c:1001: error: 'TASK_NORMAL' undeclared (first use in this function) drivers/isdn/gigaset/ev-layer.c:1495: error: 'TASK_NORMAL' undeclared (first use in this function) i'd suggest a revert of b91ecb00 instead. Ingo