From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 04 May 2010 23:37:31 +0200 Subject: [U-Boot] [PATCH 4/7] Adding uC5272 dimm module support In-Reply-To: References: <20100409225433.8E60619F36@gemini.denx.de> Message-ID: <20100504213731.49324B076D3@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear "David Wu", In message you wrote: > > > We will not accept such a mess of scriting in the top level Makefile. > It was/is a mess already. I just followed the exact top level Makefile. Yes, there is a lot of such mess already around, but we have learned our lessen and will not add any more of it. > If it is not acceptable then I'd like to know if it is OK to > -- make one separate header file in include/configs for each board > -- and one config.mk per board > -- or other methods -- advise please Use "@$(MKCONFIG) -t" like other boards do. > > Also, I don't understand why adding DIMM module support would result > > in a new config.mk file and a new linker script being added? > TEXT_BASE is changed due to changes in the memory map for different DIMM > modules with different size of SDRAM and FLASH. This is no reason to add another file - just adjust the parameters as needed. > > The additions to the board config file are an unacceptable mess, too. > You mean you cannot understand the ifdefs so you think it is a mess? But I Indeed. And I guess everybody else who is trying to figure out what the result for a specific configuration would be will have the same problems. > feel it is so neat and it supports many different configurations for > uCdimm 5272 modules. > I also can create many of these files with a few lines differences by > each. How about this? NAK. Please factor out common parts, eventually even into a separate header file like some boards / board families / vendors do. Then reduce the remaining #ifdef'fery to the needed minimum. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de They say, well, meybe it _is_ smelly, maybe it _is_ overcrowded, may- be it _is_ a bit like Hell would be if they shut the fires off and stabled a herd of incontinent cows there for a year, but you must admit that it is full of sheer, vibrant, dynamic _life_. - Terry Pratchett, _Moving Pictures_