From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 06 May 2010 12:50:26 +0200 Subject: [U-Boot] [RESEND:PATCH-V4] OMAP3EVM: Added NAND support In-Reply-To: References: <1272034546-26041-2-git-send-email-hvaibhav@ti.com> <20100505200120.4244CE59F7E@gemini.denx.de> <19F8576C6E063C45BE387C64729E7394044E351B9F@dbde02.ent.ti.com> Message-ID: <20100506105026.A80E4E8AAC9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Nishanth Menon, In message you wrote: > On Thu, May 6, 2010 at 12:36 AM, Hiremath, Vaibhav wrote: ... > > I do agree that we don't have to undef here, but agreed to Nishant's comment only because from user point of view, if user would > > like to enable ONENAND support then for him it's easy he just have to comment NAND line and make change this #define. He > > doesn't have to dig inside code to find out whether ONENAND is supported or not. Well, of course the user _has_ to dig into the code and check if the feature is supported, because there is no information what the "#undef" or the comment means - it can mean anything: - disabled here and left in so you can easily re-add it if you like - disabled because known to be unsupported or broken - disabled because untested - ... > platforms such as SDP platforms have three flash devices - nand, > onenand and nor - these are development platforms and are meant to > bootup from any of these devices based on which ever dip switch is > set. having a #undef is more elegant than /* */ and easier to use from > a developer perspective. Please provide one working configuration, or several config options, but don't try to add kind of configuration menues using "#define" / "#undef" lists. These are useless and confusing at best. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Motto of the Electrical Engineer: Working computer hardware is a lot like an erect penis: it stays up as long as you don't fuck with it.