All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Pete Harlan <pgit@pcharlan.com>
Cc: Junio C Hamano <gitster@pobox.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] clone: simplify progress message
Date: Mon, 10 May 2010 01:47:56 -0400	[thread overview]
Message-ID: <20100510054756.GB13340@coredump.intra.peff.net> (raw)
In-Reply-To: <4BE7166A.5030107@pcharlan.com>

On Sun, May 09, 2010 at 01:09:14PM -0700, Pete Harlan wrote:

> > I guess it comes down to how much detail we want to show.
> 
> For me it isn't only a matter of detail; I find "Cloning into
> bar/.git" misleading, since bar is getting more than a .git directory.

Yeah, I can buy that line of reasoning. Junio's nitpick aside, I think
most users perceive the clone process as creating the whole "bar"
directory.

> Thank you for looking at this.  I agree with you, and have added a
> second patch that implements that.

These patches look good to me. I agree with Junio about just squashing
them.

-Peff

  parent reply	other threads:[~2010-05-10  5:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-09  1:23 [PATCH/RFC] clone: have progress report mention top level dir, not git dir Pete Harlan
2010-05-09 11:02 ` Jeff King
2010-05-09 20:09   ` [PATCH v2 0/2] clone: simplify progress message Pete Harlan
2010-05-09 20:10     ` [PATCH v2 1/2] clone: have progress report mention top level dir, not git dir Pete Harlan
2010-05-09 20:11     ` [PATCH v2 2/2] clone: add bare clone to the progress message Pete Harlan
2010-05-09 22:15     ` [PATCH v2 0/2] clone: simplify " Junio C Hamano
2010-05-09 23:10       ` Pete Harlan
2010-05-10  5:47     ` Jeff King [this message]
2010-05-10 10:31       ` Michael J Gruber
2010-05-10 14:46         ` [PATCH] clone: report check out for non-bare clones Michael J Gruber
2010-05-12  1:55           ` Junio C Hamano
2010-05-12  7:59             ` Michael J Gruber
2010-05-10 23:22         ` [PATCH v2 0/2] clone: simplify progress message Pete Harlan
2010-05-11  7:27           ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100510054756.GB13340@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pgit@pcharlan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.