From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Cc: Git List <git@vger.kernel.org>, Petr Baudis <pasky@ucw.cz>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCHv2 GSoC] gitweb: Move static files into seperate subdirectory
Date: Mon, 10 May 2010 14:55:45 +0200 [thread overview]
Message-ID: <201005101455.50633.jnareb@gmail.com> (raw)
In-Reply-To: <AANLkTim2rIFDBRChBxTiWZCNmd8ozwKQzM3RZOEr3mgp@mail.gmail.com>
Only minor comments about submission itself. Patch I think is now
all right with added required changes to main Makefile.
On Mon, 10 May 2010, Pavan Kumar Sunkara wrote:
> Gitweb: Move static files into seperate subdirectory
This should be the subject of an email, like now is (only without
"Re:"), and this line should be missing from email body.
Or you need to use
Subject: gitweb: Move static files into seperate subdirectory
It is customary to start subsystem prefix with lowercase.
>
> Create a new subdirectory called 'static' in gitweb/, and move
> all static files required by gitweb.cgi when running, which means
> styles, images and Javascript code. This should make gitweb more
> readable and easier to maintain.
>
> Update t/gitweb-lib.sh to reflect this change. The default is
> now to install static files also in 'static' subdirectory in target
> directory: update Makefile, gitweb's INSTALL, README and Makefile
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
> ---
The comments about patch itself should be put *here*, between "---\n"
and diffstat.
>
> This is the new patch which includes the changes suggested by Jakub.
>
> Regarding wordwrap, all the mailing ports in my university are closed
> which leaves me only the gmail web cient which don't have any option
> to disable wordwrap. I will try to find a workaround for this. Please
> bear with my wordwrap until then.
>
> Thanks
> -Pavan
Like this.
> Makefile | 20 ++++++++++----------
> gitweb/INSTALL | 20 ++++++++++----------
> gitweb/Makefile | 20 ++++++++++----------
> gitweb/README | 13 +++++++------
> gitweb/{ => static}/git-favicon.png | Bin 115 -> 115 bytes
> gitweb/{ => static}/git-logo.png | Bin 207 -> 207 bytes
> gitweb/{ => static}/gitweb.css | 0
> gitweb/{ => static}/gitweb.js | 0
> t/gitweb-lib.sh | 6 +++---
> 9 files changed, 40 insertions(+), 39 deletions(-)
> rename gitweb/{ => static}/git-favicon.png (100%)
> rename gitweb/{ => static}/git-logo.png (100%)
> rename gitweb/{ => static}/gitweb.css (100%)
> rename gitweb/{ => static}/gitweb.js (100%)
[...]
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-05-10 12:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 13:56 [Patch 001/GSoC] Move static files into subdir Pavan Kumar Sunkara
2010-05-09 17:10 ` Christian Couder
2010-05-09 17:48 ` Pavan Kumar Sunkara
2010-05-09 22:13 ` Jakub Narebski
2010-05-10 11:44 ` Pavan Kumar Sunkara
2010-05-10 11:53 ` Ramkumar Ramachandra
2010-05-10 12:55 ` Jakub Narebski [this message]
2010-05-10 13:01 ` [PATCHv2 GSoC] gitweb: Move static files into seperate subdirectory Pavan Kumar Sunkara
2010-05-11 23:27 ` Jakub Narebski
2010-05-12 5:15 ` Pavan Kumar Sunkara
2010-05-12 7:52 ` [PATCHv3 " Pavan Kumar Sunkara
2010-05-13 8:54 ` Christian Couder
2010-05-13 9:01 ` Pavan Kumar Sunkara
2010-05-14 16:15 ` Pavan Kumar Sunkara
2010-05-14 21:25 ` Jakub Narebski
2010-05-15 8:47 ` Pavan Kumar Sunkara
2010-05-18 0:06 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005101455.50633.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.