All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jan Kara <jack@suse.cz>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: linux-next: manual merge of the ext3 tree with Linus' tree
Date: Sat, 22 May 2010 15:45:32 +1000	[thread overview]
Message-ID: <20100522154532.bc0f8008.sfr@canb.auug.org.au> (raw)

Hi Jan,

Today's linux-next merge of the ext3 tree got a conflict in fs/super.c
between commits b20bd1a5e78af267dc4b6e1ffed48d5d776302c5 ("get rid of
S_BIAS"), 1712ac8fda7d8bc4dc921f5777b7423aacad7263 ("Saner locking around
deactivate_super()") and e1e46bf1866317d4f86f66bf18d3f07317d9f9ee ("Trim
includes in fs/super.c") from Linus' tree and commits
c3134141c78d5ea233a08b703b553e70cfb5c585 ("quota: move unmount handling
into the filesystem") and cdb89ca659f5a39edf88f3c55e545ea3347533d1
("quota: explicitly set ->dq_op and ->s_qcop") from the ext3 tree.

I fixed it all up (see below) and can carry the fix for a while.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc fs/super.c
index 69688b1,2e0811f..0000000
--- a/fs/super.c
+++ b/fs/super.c
@@@ -22,15 -22,22 +22,14 @@@
  
  #include <linux/module.h>
  #include <linux/slab.h>
 -#include <linux/init.h>
 -#include <linux/smp_lock.h>
  #include <linux/acct.h>
  #include <linux/blkdev.h>
- #include <linux/quotaops.h>
 -#include <linux/namei.h>
  #include <linux/mount.h>
  #include <linux/security.h>
 -#include <linux/syscalls.h>
 -#include <linux/vfs.h>
  #include <linux/writeback.h>		/* for the emergency remount stuff */
  #include <linux/idr.h>
 -#include <linux/kobject.h>
  #include <linux/mutex.h>
 -#include <linux/file.h>
  #include <linux/backing-dev.h>
 -#include <asm/uaccess.h>
  #include "internal.h"
  
  
@@@ -146,21 -175,21 +143,20 @@@ void put_super(struct super_block *sb
  
  
  /**
 - *	deactivate_super	-	drop an active reference to superblock
 + *	deactivate_locked_super	-	drop an active reference to superblock
   *	@s: superblock to deactivate
   *
 - *	Drops an active reference to superblock, acquiring a temprory one if
 - *	there is no active references left.  In that case we lock superblock,
 + *	Drops an active reference to superblock, converting it into a temprory
 + *	one if there is no other active references left.  In that case we
   *	tell fs driver to shut it down and drop the temporary reference we
   *	had just acquired.
 + *
 + *	Caller holds exclusive lock on superblock; that lock is released.
   */
 -void deactivate_super(struct super_block *s)
 +void deactivate_locked_super(struct super_block *s)
  {
  	struct file_system_type *fs = s->s_type;
 -	if (atomic_dec_and_lock(&s->s_active, &sb_lock)) {
 -		s->s_count -= S_BIAS-1;
 -		spin_unlock(&sb_lock);
 -		down_write(&s->s_umount);
 +	if (atomic_dec_and_test(&s->s_active)) {
- 		vfs_dq_off(s, 0);
  		fs->kill_sb(s);
  		put_filesystem(fs);
  		put_super(s);

             reply	other threads:[~2010-05-22  6:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22  5:45 Stephen Rothwell [this message]
2010-05-25 21:55 ` linux-next: manual merge of the ext3 tree with Linus' tree Jan Kara
2011-11-02  0:59 Stephen Rothwell
2012-01-10  1:22 Stephen Rothwell
2012-01-10 12:01 ` Jan Kara
2021-06-18  0:32 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100522154532.bc0f8008.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.