From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754830Ab0EWOXs (ORCPT ); Sun, 23 May 2010 10:23:48 -0400 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:45524 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754308Ab0EWOXq (ORCPT ); Sun, 23 May 2010 10:23:46 -0400 X-Sasl-enc: a7wWClySgyiqv513GizjPSi2AcPqz7XBfAR44DolpZx0 1274624625 Date: Sun, 23 May 2010 09:23:44 -0500 From: Roman Kononov To: Dave Chinner Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: WARNING in xfs_lwr.c, xfs_write() Message-ID: <20100523092344.0fcaab42@aaa.pulp.binarylife.net> In-Reply-To: <20100523101856.GL2150@dastard> References: <20100523002023.41f5a5c8@aaa.pulp.binarylife.net> <20100523101856.GL2150@dastard> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2010-05-23, 20:18:56 +1000, Dave Chinner wrote: > You've got some workload that is mixing direct IO writes with some > form of buffered or mmap IO on the same file and they are racing. > Mixing different types of IO on the one inode is also known as A > Really Bad Idea because there is no guarantee of coherency between > them.... > > Can you find out what the application is triggering this? This is severely modified Postgresql, which does mix direct IO with buffered one. You say "they are racing". Do you mean that this can cause file system corruption? Doest it simply warn that direct user data races with buffered user data and one of them wins? This warning "taints" the kernel. Should it be safe to do different types of IOs on different non-overlapping 4-KiB-aligned regions of the same file (I am unsure if this is what the application really does)? Thanks, Roman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o4NELPV6125472 for ; Sun, 23 May 2010 09:21:26 -0500 Received: from out3.smtp.messagingengine.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 167C23678C0 for ; Sun, 23 May 2010 07:23:46 -0700 (PDT) Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com [66.111.4.27]) by cuda.sgi.com with ESMTP id x3HbUoczSuBvNVNf for ; Sun, 23 May 2010 07:23:46 -0700 (PDT) Date: Sun, 23 May 2010 09:23:44 -0500 From: Roman Kononov Subject: Re: WARNING in xfs_lwr.c, xfs_write() Message-ID: <20100523092344.0fcaab42@aaa.pulp.binarylife.net> In-Reply-To: <20100523101856.GL2150@dastard> References: <20100523002023.41f5a5c8@aaa.pulp.binarylife.net> <20100523101856.GL2150@dastard> Mime-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com On 2010-05-23, 20:18:56 +1000, Dave Chinner wrote: > You've got some workload that is mixing direct IO writes with some > form of buffered or mmap IO on the same file and they are racing. > Mixing different types of IO on the one inode is also known as A > Really Bad Idea because there is no guarantee of coherency between > them.... > > Can you find out what the application is triggering this? This is severely modified Postgresql, which does mix direct IO with buffered one. You say "they are racing". Do you mean that this can cause file system corruption? Doest it simply warn that direct user data races with buffered user data and one of them wins? This warning "taints" the kernel. Should it be safe to do different types of IOs on different non-overlapping 4-KiB-aligned regions of the same file (I am unsure if this is what the application really does)? Thanks, Roman _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs