From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751942Ab0FCMDy (ORCPT ); Thu, 3 Jun 2010 08:03:54 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:48171 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750969Ab0FCMDx (ORCPT ); Thu, 3 Jun 2010 08:03:53 -0400 Date: Thu, 3 Jun 2010 13:03:51 +0100 From: Mark Brown To: Wan ZongShun Cc: Lars-Peter Clausen , Ralf Baechle , linux-mips@linux-mips.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [alsa-devel] [RFC][PATCH 20/26] alsa: ASoC: Add JZ4740 codec driver Message-ID: <20100603120350.GC2762@rakim.wolfsonmicro.main> References: <1275505397-16758-1-git-send-email-lars@metafoo.de> <1275505950-17334-4-git-send-email-lars@metafoo.de> <4C074171.2080106@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C074171.2080106@gmail.com> X-Cookie: In the next world, you're on your own. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 03, 2010 at 01:45:21PM +0800, Wan ZongShun wrote: > Your all the patches have two kinds of 'WARNING:',as following: > (1)'WARNING: line over 80 characters' and > Please make a line less than 80 characters. You need to apply a certain degree of taste when looking at checkpatch warnings, particularly things like line length. Sometimes fixing the warning for the sake of fixing the warning makes the code uglier than it would be with whatever the style issue that's been identified is. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC][PATCH 20/26] alsa: ASoC: Add JZ4740 codec driver Date: Thu, 3 Jun 2010 13:03:51 +0100 Message-ID: <20100603120350.GC2762@rakim.wolfsonmicro.main> References: <1275505397-16758-1-git-send-email-lars@metafoo.de> <1275505950-17334-4-git-send-email-lars@metafoo.de> <4C074171.2080106@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 2B1D924413 for ; Thu, 3 Jun 2010 14:03:52 +0200 (CEST) Content-Disposition: inline In-Reply-To: <4C074171.2080106@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Wan ZongShun Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Lars-Peter Clausen , linux-kernel@vger.kernel.org, Ralf Baechle , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Jun 03, 2010 at 01:45:21PM +0800, Wan ZongShun wrote: > Your all the patches have two kinds of 'WARNING:',as following: > (1)'WARNING: line over 80 characters' and > Please make a line less than 80 characters. You need to apply a certain degree of taste when looking at checkpatch warnings, particularly things like line length. Sometimes fixing the warning for the sake of fixing the warning makes the code uglier than it would be with whatever the style issue that's been identified is.