From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754833Ab0FHMBt (ORCPT ); Tue, 8 Jun 2010 08:01:49 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:44207 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007Ab0FHMBr (ORCPT ); Tue, 8 Jun 2010 08:01:47 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: "Luis Claudio R. Goncalves" , LKML , linux-mm , Oleg Nesterov , David Rientjes , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin , Minchan Kim Subject: [PATCH 08/10] oom: use send_sig() instead force_sig() Cc: kosaki.motohiro@jp.fujitsu.com In-Reply-To: <20100608204621.767A.A69D9226@jp.fujitsu.com> References: <20100608204621.767A.A69D9226@jp.fujitsu.com> Message-Id: <20100608210000.7692.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Tue, 8 Jun 2010 21:01:44 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg, I parsed your mention mean following patch, correct? =========================================== Oleg pointed out oom_kill.c has force_sig() abuse. force_sig() mean ignore signal mask. but SIGKILL itself is not maskable. So, we can use send_sig() sefely. Cc: Oleg Nesterov Signed-off-by: KOSAKI Motohiro --- mm/oom_kill.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index e7d3a5d..599f977 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -399,7 +399,7 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem) p->rt.time_slice = HZ; set_tsk_thread_flag(p, TIF_MEMDIE); - force_sig(SIGKILL, p); + send_sig(SIGKILL, p, 1); return 0; } -- 1.6.5.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id B14326B0237 for ; Tue, 8 Jun 2010 08:01:48 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp ([10.0.50.71]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o58C1kXd020570 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 8 Jun 2010 21:01:46 +0900 Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 5488845DE50 for ; Tue, 8 Jun 2010 21:01:46 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 337B745DE4F for ; Tue, 8 Jun 2010 21:01:46 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 1ECADE18003 for ; Tue, 8 Jun 2010 21:01:46 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id BA293E08001 for ; Tue, 8 Jun 2010 21:01:45 +0900 (JST) From: KOSAKI Motohiro Subject: [PATCH 08/10] oom: use send_sig() instead force_sig() In-Reply-To: <20100608204621.767A.A69D9226@jp.fujitsu.com> References: <20100608204621.767A.A69D9226@jp.fujitsu.com> Message-Id: <20100608210000.7692.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Tue, 8 Jun 2010 21:01:44 +0900 (JST) Sender: owner-linux-mm@kvack.org To: "Luis Claudio R. Goncalves" , LKML , linux-mm , Oleg Nesterov , David Rientjes , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin , Minchan Kim Cc: kosaki.motohiro@jp.fujitsu.com List-ID: Oleg, I parsed your mention mean following patch, correct? =========================================== Oleg pointed out oom_kill.c has force_sig() abuse. force_sig() mean ignore signal mask. but SIGKILL itself is not maskable. So, we can use send_sig() sefely. Cc: Oleg Nesterov Signed-off-by: KOSAKI Motohiro --- mm/oom_kill.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index e7d3a5d..599f977 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -399,7 +399,7 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem) p->rt.time_slice = HZ; set_tsk_thread_flag(p, TIF_MEMDIE); - force_sig(SIGKILL, p); + send_sig(SIGKILL, p, 1); return 0; } -- 1.6.5.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org