From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758256Ab0FIVGO (ORCPT ); Wed, 9 Jun 2010 17:06:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6579 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965Ab0FIVGN (ORCPT ); Wed, 9 Jun 2010 17:06:13 -0400 Date: Wed, 9 Jun 2010 23:03:59 +0200 From: Oleg Nesterov To: David Rientjes Cc: KOSAKI Motohiro , Roland McGrath , LKML , linux-mm , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin Subject: Re: [PATCH] oom: Make coredump interruptible Message-ID: <20100609210358.GA16545@redhat.com> References: <20100602185812.4B5894A549@magilla.sf.frob.com> <20100602203827.GA29244@redhat.com> <20100604194635.72D3.A69D9226@jp.fujitsu.com> <20100604112721.GA12582@redhat.com> <20100609195309.GA6899@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09, David Rientjes wrote: > > On Wed, 9 Jun 2010, Oleg Nesterov wrote: > > > --- x/mm/oom_kill.c > > +++ x/mm/oom_kill.c > > @@ -414,6 +414,7 @@ static void __oom_kill_task(struct task_ > > p->rt.time_slice = HZ; > > set_tsk_thread_flag(p, TIF_MEMDIE); > > > > + clear_bit(MMF_COREDUMP, &p->mm->flags); > > force_sig(SIGKILL, p); > > } > > > > This requires task_lock(p). Yes, yes, sure. This is only template. I'll wait for the next mmotm to send the actual patch on top of recent changes. Unless Kosaki/Roland have other ideas. Imho, we really need to fix the coredump/oom problem. Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 91C146B0071 for ; Wed, 9 Jun 2010 17:05:38 -0400 (EDT) Date: Wed, 9 Jun 2010 23:03:59 +0200 From: Oleg Nesterov Subject: Re: [PATCH] oom: Make coredump interruptible Message-ID: <20100609210358.GA16545@redhat.com> References: <20100602185812.4B5894A549@magilla.sf.frob.com> <20100602203827.GA29244@redhat.com> <20100604194635.72D3.A69D9226@jp.fujitsu.com> <20100604112721.GA12582@redhat.com> <20100609195309.GA6899@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org To: David Rientjes Cc: KOSAKI Motohiro , Roland McGrath , LKML , linux-mm , Andrew Morton , KAMEZAWA Hiroyuki , Nick Piggin List-ID: On 06/09, David Rientjes wrote: > > On Wed, 9 Jun 2010, Oleg Nesterov wrote: > > > --- x/mm/oom_kill.c > > +++ x/mm/oom_kill.c > > @@ -414,6 +414,7 @@ static void __oom_kill_task(struct task_ > > p->rt.time_slice = HZ; > > set_tsk_thread_flag(p, TIF_MEMDIE); > > > > + clear_bit(MMF_COREDUMP, &p->mm->flags); > > force_sig(SIGKILL, p); > > } > > > > This requires task_lock(p). Yes, yes, sure. This is only template. I'll wait for the next mmotm to send the actual patch on top of recent changes. Unless Kosaki/Roland have other ideas. Imho, we really need to fix the coredump/oom problem. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org