From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1 Date: Mon, 14 Jun 2010 11:49:43 +0300 Message-ID: <20100614084943.GA26938@fermat.math.technion.ac.il> References: <1276431753-nyh@il.ibm.com> <201006131225.o5DCP79H012922@rice.haifa.ibm.com> <4C15E95D.9000300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mailgw10.technion.ac.il ([132.68.225.10]:6916 "EHLO mailgw10.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755622Ab0FNJBz (ORCPT ); Mon, 14 Jun 2010 05:01:55 -0400 Content-Disposition: inline In-Reply-To: <4C15E95D.9000300@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 14, 2010, Avi Kivity wrote about "Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1": > On 06/13/2010 03:25 PM, Nadav Har'El wrote: > >+#define VMCS12_REVISION 0x11e57ed0 > > > > Where did this number come from? It's not from real hardware, yes? Basically, we are presenting emulated VMX for the L1 guest, complete with its own VMCS structure. This structure needs to have some VMCS revision id, which should be an arbitrary number that we invent - it is not related to any revision id that any real hardware uses. If you look closely, you can see that the number I used is leetspeak for "Nested0" ;-) As you can see in the following patches, MSR_IA32_VMX_BASIC will return this arbitrary VMCS revision id, and and VMPTRLD will verify that the VMCS region that L1 is trying to load contains this revision id. -- Nadav Har'El | Monday, Jun 14 2010, 2 Tammuz 5770 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |If you're looking for a helping hand, http://nadav.harel.org.il |look first at the end of your arm.