From: tytso@mit.edu
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] Only honor the FIGETBSZ ioctl for regular files, directories, and symlinks
Date: Mon, 14 Jun 2010 10:12:56 -0400 [thread overview]
Message-ID: <20100614141256.GB22163@thunk.org> (raw)
In-Reply-To: <20100614140730.GA30779@infradead.org>
On Mon, Jun 14, 2010 at 10:07:30AM -0400, Christoph Hellwig wrote:
> On Mon, Jun 14, 2010 at 10:05:10AM -0400, Theodore Ts'o wrote:
> > FIGETBSZ has an ioctl number of _IO(0x00,2) == 2, which can conflict
> > with device driver ioctls. Let's avoid the potential for problems by
> > only honoring the ioctl number for files where this ioctl is likely
> > going to be useful: regular files, directories, and symlinks.
> >
> > Thanks to Johannes Stezenbach for pointing this consequence of commit
> > 19ba0559.
>
> ioctl operate on a file descriptor, so you never call them on
> symbolic links.
Oops, good point.
> A comment explaining why we fall through here for special files is
> almost required. Without that the chance of breaking it during the
> next random cleanup are far too high.
Sigh. I had fixed that, but I failed to save emacs buffer before
creating commit. Will resend with both fixes.
- Ted
next prev parent reply other threads:[~2010-06-14 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100614110252.GB32224@sig21.net>
2010-06-14 12:36 ` FIGETBSZ ioctl conflict Johannes Stezenbach
2010-06-14 13:42 ` tytso
2010-06-14 14:05 ` [PATCH] Only honor the FIGETBSZ ioctl for regular files, directories, and symlinks Theodore Ts'o
2010-06-14 14:07 ` Christoph Hellwig
2010-06-14 14:12 ` tytso [this message]
2010-06-14 14:15 ` [PATCH -v2] Only honor the FIGETBSZ ioctl for regular files and directories Theodore Ts'o
2010-06-14 14:17 ` [PATCH -v3] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614141256.GB22163@thunk.org \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.