From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757001Ab0FOKOP (ORCPT ); Tue, 15 Jun 2010 06:14:15 -0400 Received: from gir.skynet.ie ([193.1.99.77]:47830 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756841Ab0FOKOK (ORCPT ); Tue, 15 Jun 2010 06:14:10 -0400 Date: Tue, 15 Jun 2010 11:13:51 +0100 From: Mel Gorman To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , Andrew Morton Subject: Re: [PATCH 06/12] vmscan: simplify shrink_inactive_list() Message-ID: <20100615101351.GA26788@csn.ul.ie> References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-7-git-send-email-mel@csn.ul.ie> <4C166F95.3030907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4C166F95.3030907@redhat.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2010 at 02:06:13PM -0400, Rik van Riel wrote: > On 06/14/2010 07:17 AM, Mel Gorman wrote: >> From: KOSAKI Motohiro >> >> Now, max_scan of shrink_inactive_list() is always passed less than >> SWAP_CLUSTER_MAX. then, we can remove scanning pages loop in it. >> This patch also help stack diet. >> >> detail >> - remove "while (nr_scanned< max_scan)" loop >> - remove nr_freed (now, we use nr_reclaimed directly) >> - remove nr_scan (now, we use nr_scanned directly) >> - rename max_scan to nr_to_scan >> - pass nr_to_scan into isolate_pages() directly instead >> using SWAP_CLUSTER_MAX >> >> Signed-off-by: KOSAKI Motohiro >> Reviewed-by: Johannes Weiner > > Other than the weird whitespace below, > Not sure where this came out of. It's not in my local patch file nor in my working tree. Very odd. > Reviewed-by: Rik van Riel > Thanks >> + /* >> + * If we are direct reclaiming for contiguous pages and we do >> + * not reclaim everything in the list, try again and wait >> + * for IO to complete. This will stall high-order allocations >> + * but that should be acceptable to the caller >> + */ >> + if (nr_reclaimed< nr_taken&& !current_is_kswapd()&& sc->lumpy_reclaim_mode) { >> + congestion_wait(BLK_RW_ASYNC, HZ/10); > > -- > All rights reversed > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [PATCH 06/12] vmscan: simplify shrink_inactive_list() Date: Tue, 15 Jun 2010 11:13:51 +0100 Message-ID: <20100615101351.GA26788@csn.ul.ie> References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-7-git-send-email-mel@csn.ul.ie> <4C166F95.3030907@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki , Andrew Morton To: Rik van Riel Return-path: Content-Disposition: inline In-Reply-To: <4C166F95.3030907@redhat.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jun 14, 2010 at 02:06:13PM -0400, Rik van Riel wrote: > On 06/14/2010 07:17 AM, Mel Gorman wrote: >> From: KOSAKI Motohiro >> >> Now, max_scan of shrink_inactive_list() is always passed less than >> SWAP_CLUSTER_MAX. then, we can remove scanning pages loop in it. >> This patch also help stack diet. >> >> detail >> - remove "while (nr_scanned< max_scan)" loop >> - remove nr_freed (now, we use nr_reclaimed directly) >> - remove nr_scan (now, we use nr_scanned directly) >> - rename max_scan to nr_to_scan >> - pass nr_to_scan into isolate_pages() directly instead >> using SWAP_CLUSTER_MAX >> >> Signed-off-by: KOSAKI Motohiro >> Reviewed-by: Johannes Weiner > > Other than the weird whitespace below, > Not sure where this came out of. It's not in my local patch file nor in my working tree. Very odd. > Reviewed-by: Rik van Riel > Thanks >> + /* >> + * If we are direct reclaiming for contiguous pages and we do >> + * not reclaim everything in the list, try again and wait >> + * for IO to complete. This will stall high-order allocations >> + * but that should be acceptable to the caller >> + */ >> + if (nr_reclaimed< nr_taken&& !current_is_kswapd()&& sc->lumpy_reclaim_mode) { >> + congestion_wait(BLK_RW_ASYNC, HZ/10); > > -- > All rights reversed > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org