On 2010.06.14 18:19:46 -0700, Eric Anholt wrote:
> On Sat, 12 Jun 2010 14:32:21 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > From: Zhao Yakui <yakui.zhao@intel.com>
> > 
> > This one adds support for eDP that connected on PCH DP-D port
> > instead of CPU DP-A port, and only DP-D port could be used for eDP.
> > 
> > https://bugs.freedesktop.org/show_bug.cgi?id=27220
> 
> Instead of changing a ton of EDP checks to be EDP || PCH_EDP, why aren't
> you just setting the output type to edp when you detect that DPD is EDP?

There's obviously difference between eDP from CPU and eDP from PCH, e.g no FDI
link setup for CPU eDP, so not fit in same output type. Or do you think a new
output type might be better for it?

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827