From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759830Ab0FPXtJ (ORCPT ); Wed, 16 Jun 2010 19:49:09 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52935 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756041Ab0FPXtG (ORCPT ); Wed, 16 Jun 2010 19:49:06 -0400 Date: Wed, 16 Jun 2010 16:48:01 -0700 From: Andrew Morton To: Mel Gorman Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki Subject: Re: [PATCH 09/12] vmscan: Setup pagevec as late as possible in shrink_page_list() Message-Id: <20100616164801.9d3c0d99.akpm@linux-foundation.org> In-Reply-To: <1276514273-27693-10-git-send-email-mel@csn.ul.ie> References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-10-git-send-email-mel@csn.ul.ie> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Jun 2010 12:17:50 +0100 Mel Gorman wrote: > shrink_page_list() sets up a pagevec to release pages as according as they > are free. It uses significant amounts of stack on the pagevec. This > patch adds pages to be freed via pagevec to a linked list which is then > freed en-masse at the end. This avoids using stack in the main path that > potentially calls writepage(). > hm, spose so. I cen't see any trivial way to eliminate the local pagevec there. > + if (pagevec_count(&freed_pvec)) > + __pagevec_free(&freed_pvec); > ... > - if (pagevec_count(&freed_pvec)) > - __pagevec_free(&freed_pvec); That's an open-coded pagevec_free(). From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 09/12] vmscan: Setup pagevec as late as possible in shrink_page_list() Date: Wed, 16 Jun 2010 16:48:01 -0700 Message-ID: <20100616164801.9d3c0d99.akpm@linux-foundation.org> References: <1276514273-27693-1-git-send-email-mel@csn.ul.ie> <1276514273-27693-10-git-send-email-mel@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , KAMEZAWA Hiroyuki To: Mel Gorman Return-path: In-Reply-To: <1276514273-27693-10-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 14 Jun 2010 12:17:50 +0100 Mel Gorman wrote: > shrink_page_list() sets up a pagevec to release pages as according as they > are free. It uses significant amounts of stack on the pagevec. This > patch adds pages to be freed via pagevec to a linked list which is then > freed en-masse at the end. This avoids using stack in the main path that > potentially calls writepage(). > hm, spose so. I cen't see any trivial way to eliminate the local pagevec there. > + if (pagevec_count(&freed_pvec)) > + __pagevec_free(&freed_pvec); > ... > - if (pagevec_count(&freed_pvec)) > - __pagevec_free(&freed_pvec); That's an open-coded pagevec_free(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org