[Qemu-devel] Re: [PATCH v4 7/7] MIPS: add PMON BIOS used by fulong mini pc

From: Aurelien Jarno <aurelien@aurel32.net>
To: Huacai Chen <zltjiangshi@gmail.com>
Cc: blauwirbel@gmail.com, yamahata@valinux.co.jp, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v4 7/7] MIPS: add PMON BIOS used by fulong mini pc
Date: Mon, 21 Jun 2010 00:39:17 +0200	[thread overview]
Message-ID: <20100620223917.GA9122@hall.aurel32.net> (raw)
In-Reply-To: <1275734493-5254-1-git-send-email-zltjiangshi@gmail.com>

On Sat, Jun 05, 2010 at 06:41:33PM +0800, Huacai Chen wrote:
> Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
> ---
>  pc-bios/README            |   13 +++++++++++++
>  pc-bios/pmon_fulong2e.bin |  Bin 0 -> 348188 bytes
>  2 files changed, 13 insertions(+), 0 deletions(-)
>  create mode 100755 pc-bios/pmon_fulong2e.bin
> 
> diff --git a/pc-bios/README b/pc-bios/README
> index e62b4cd..d146acf 100644
> --- a/pc-bios/README
> +++ b/pc-bios/README
> @@ -31,3 +31,16 @@
>  - The S390 zipl loader is an addition to the official IBM s390-tools
>    package. That fork is maintained in its own git repository at:
>    git://repo.or.cz/s390-tools.git
> +
> +- The PMON BIOS (pmon_fulong2e.bin) comes from
> +  http://www.loongson.cn/support/git/
> +  If you want to build PMON from source, first git-clone the source
> +  from the git repository at:
> +  http://www.loongson.cn/support/git/pmon
> +  Then follow the "Compile Guide" available at:
> +  http://dev.lemote.com/code/pmon
> +
> +  Notes:
> +  1, don't use the source at http://dev.lemote.com/http_git/pmon.git
> +  2, use "Bonito2edev" to replace "dir_corresponding_to_your_target_hardware"
> +  in the "Compile Guide".

While the patch itself looks good, I am concerned by the license of PMON
which is a BSD license with an advertisement clause:

|  * 3. All advertising materials mentioning features or use of this software
|  *    must display the following acknowledgement:
|  *      This product includes software developed for Rtmx, Inc by
|  *      Opsycon Open System Consulting AB, Sweden.
|  *      This product includes software developed by Opsycon AB.
|  *      This product includes software developed by ipUnplugged AB.

This license is not compatible with the GPL, but it's not a problem for
us as the PMON code is not linked with QEMU. On the other hand, the
question is what is considered to be an advertisement? Should we put 
such acknowledgment on the QEMU website? On websites related to QEMU?

I don't really know what to do here, opinions are welcome.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net