From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: hch@lst.de
Cc: fujita.tomonori@lab.ntt.co.jp, snitzer@redhat.com,
axboe@kernel.dk, dm-devel@redhat.com, James.Bottomley@suse.de,
linux-kernel@vger.kernel.org, martin.petersen@oracle.com,
akpm@linux-foundation.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] block: fix leaks associated with discard request payload
Date: Sun, 27 Jun 2010 21:32:07 +0900 [thread overview]
Message-ID: <20100627212952D.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <20100627110712.GA14511@lst.de>
On Sun, 27 Jun 2010 13:07:12 +0200
Christoph Hellwig <hch@lst.de> wrote:
> > How about this?
>
> As I tried to explain before this utterly confuses the I/O completion
> path. With the patch applied even a simple mkfs.xfs that issues discard
> just hangs.
Wired. I just tried mkfs.xfs against scsi_debug with my block patches
(I saw one discard command). Seemed that it worked fine.
next prev parent reply other threads:[~2010-06-27 12:32 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 14:59 [PATCH, RFC] block: don't allocate a payload for discard request Christoph Hellwig
2010-06-19 4:25 ` Mike Snitzer
2010-06-22 18:00 ` Mike Snitzer
2010-06-26 19:56 ` [PATCH 1/2] block: fix leaks associated with discard request payload Mike Snitzer
2010-06-27 8:49 ` FUJITA Tomonori
2010-06-27 9:26 ` Christoph Hellwig
2010-06-27 10:01 ` FUJITA Tomonori
2010-06-27 10:35 ` FUJITA Tomonori
2010-06-27 11:07 ` Christoph Hellwig
2010-06-27 12:32 ` FUJITA Tomonori [this message]
2010-06-27 14:16 ` Mike Snitzer
2010-06-27 15:35 ` Christoph Hellwig
2010-06-27 16:23 ` FUJITA Tomonori
2010-06-27 15:33 ` Christoph Hellwig
2010-06-28 7:57 ` Christoph Hellwig
2010-06-28 8:14 ` FUJITA Tomonori
2010-06-28 8:18 ` Jens Axboe
2010-06-28 8:45 ` FUJITA Tomonori
2010-06-28 8:45 ` FUJITA Tomonori
2010-06-28 15:25 ` Christoph Hellwig
2010-06-30 11:55 ` FUJITA Tomonori
2010-07-01 4:21 ` FUJITA Tomonori
2010-06-27 9:38 ` Christoph Hellwig
2010-06-27 15:29 ` James Bottomley
2010-06-28 17:16 ` Martin K. Petersen
2010-06-29 8:00 ` Boaz Harrosh
2010-06-29 22:28 ` [dm-devel] " Mikulas Patocka
2010-06-29 23:03 ` James Bottomley
2010-06-29 23:51 ` Mike Snitzer
2010-06-29 23:51 ` Mike Snitzer
2010-06-30 0:11 ` [dm-devel] " Mikulas Patocka
2010-06-30 14:22 ` James Bottomley
2010-06-30 15:36 ` Mike Snitzer
2010-06-30 16:26 ` James Bottomley
2010-07-01 12:28 ` [dm-devel] " Mikulas Patocka
2010-07-01 12:46 ` Mike Snitzer
2010-07-01 14:03 ` Mikulas Patocka
2010-07-01 14:03 ` Mikulas Patocka
2010-07-01 12:49 ` [dm-devel] " Alasdair G Kergon
2010-06-30 8:32 ` Boaz Harrosh
2010-06-30 8:42 ` Christoph Hellwig
2010-06-30 10:25 ` Boaz Harrosh
2010-06-30 10:41 ` Christoph Hellwig
2010-06-30 10:57 ` Boaz Harrosh
2010-06-30 12:18 ` Mike Snitzer
2010-06-26 19:56 ` [PATCH 2/2] block: defer the use of inline biovecs for discard requests Mike Snitzer
2010-06-27 9:39 ` Christoph Hellwig
2010-06-27 14:00 ` Mike Snitzer
2010-06-27 14:55 ` [PATCH 2/2 v2] " Mike Snitzer
2010-06-27 15:33 ` Christoph Hellwig
2010-06-28 10:33 ` [PATCH 2/2] " FUJITA Tomonori
2010-06-28 12:29 ` Mike Snitzer
2010-06-28 15:15 ` FUJITA Tomonori
2010-06-28 15:31 ` Mike Snitzer
2010-06-28 12:34 ` Jens Axboe
2010-06-28 12:37 ` Mike Snitzer
2010-06-28 12:41 ` Jens Axboe
2010-06-28 12:44 ` Christoph Hellwig
2010-06-28 12:49 ` Jens Axboe
2010-06-28 12:45 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100627212952D.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.