* linux-next: build failure after merge of the sound tree
@ 2010-06-24 3:03 Stephen Rothwell
2010-06-24 6:11 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2010-06-24 3:03 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Daniel Mack
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/usb/mixer.c: In function 'get_ctl_value_v1':
sound/usb/mixer.c:308: error: 'struct usb_mixer_interface' has no member named 'ctrlif'
Caused by commit 3d8d4dcfd423b01ef7ea7c3c97720764b7adb6df ("ALSA:
usb-audio: simplify control interface access"). Grep is your friend ...
I have used the sound tree from next-20100623 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2010-06-24 3:03 linux-next: build failure after merge of the sound tree Stephen Rothwell
@ 2010-06-24 6:11 ` Takashi Iwai
2010-06-28 16:33 ` Daniel Mack
0 siblings, 1 reply; 32+ messages in thread
From: Takashi Iwai @ 2010-06-24 6:11 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Daniel Mack
At Thu, 24 Jun 2010 13:03:41 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/usb/mixer.c: In function 'get_ctl_value_v1':
> sound/usb/mixer.c:308: error: 'struct usb_mixer_interface' has no member named 'ctrlif'
>
> Caused by commit 3d8d4dcfd423b01ef7ea7c3c97720764b7adb6df ("ALSA:
> usb-audio: simplify control interface access"). Grep is your friend ...
>
> I have used the sound tree from next-20100623 for today.
Fixed now. I've forgotten the build tests with debug options...
thanks,
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2010-06-24 6:11 ` Takashi Iwai
@ 2010-06-28 16:33 ` Daniel Mack
0 siblings, 0 replies; 32+ messages in thread
From: Daniel Mack @ 2010-06-28 16:33 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Stephen Rothwell, linux-next, linux-kernel
On Thu, Jun 24, 2010 at 08:11:00AM +0200, Takashi Iwai wrote:
> At Thu, 24 Jun 2010 13:03:41 +1000,
> Stephen Rothwell wrote:
> >
> > Hi Takashi,
> >
> > After merging the sound tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/usb/mixer.c: In function 'get_ctl_value_v1':
> > sound/usb/mixer.c:308: error: 'struct usb_mixer_interface' has no member named 'ctrlif'
> >
> > Caused by commit 3d8d4dcfd423b01ef7ea7c3c97720764b7adb6df ("ALSA:
> > usb-audio: simplify control interface access"). Grep is your friend ...
> >
> > I have used the sound tree from next-20100623 for today.
>
> Fixed now. I've forgotten the build tests with debug options...
Oops, sorry and thanks for fixing this up!
Daniel
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2023-08-18 3:12 Stephen Rothwell
2023-08-18 11:47 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2023-08-18 3:12 UTC (permalink / raw)
To: Takashi Iwai
Cc: Curtis Malainey, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
sound/aoa/soundbus/i2sbus/pcm.c: In function 'i2sbus_attach_codec':
sound/aoa/soundbus/i2sbus/pcm.c:975:61: error: invalid type argument of '->' (have 'struct snd_pcm_str')
975 | dev->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK]->dev.parent =
| ^~
sound/aoa/soundbus/i2sbus/pcm.c:992:60: error: invalid type argument of '->' (have 'struct snd_pcm_str')
992 | dev->pcm->streams[SNDRV_PCM_STREAM_CAPTURE]->dev.parent =
| ^~
Caused by commit
bc41a7228ced ("ALSA: pcm: Don't embed device")
I have used the sound tree from next-20230817 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2023-08-18 3:12 Stephen Rothwell
@ 2023-08-18 11:47 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2023-08-18 11:47 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Takashi Iwai, Curtis Malainey, Linux Kernel Mailing List,
Linux Next Mailing List
On Fri, 18 Aug 2023 05:12:55 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> sound/aoa/soundbus/i2sbus/pcm.c: In function 'i2sbus_attach_codec':
> sound/aoa/soundbus/i2sbus/pcm.c:975:61: error: invalid type argument of '->' (have 'struct snd_pcm_str')
> 975 | dev->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK]->dev.parent =
> | ^~
> sound/aoa/soundbus/i2sbus/pcm.c:992:60: error: invalid type argument of '->' (have 'struct snd_pcm_str')
> 992 | dev->pcm->streams[SNDRV_PCM_STREAM_CAPTURE]->dev.parent =
> | ^~
>
> Caused by commit
>
> bc41a7228ced ("ALSA: pcm: Don't embed device")
>
> I have used the sound tree from next-20230817 for today.
There were obvious typos in the patch, and fixed in for-next branch
now. Sorry for the mess.
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2023-05-24 3:54 Stephen Rothwell
2023-05-24 7:14 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2023-05-24 3:54 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (powerpc
allyesconfig) failed like this:
In file included from sound/core/seq/seq_ump_convert.c:11:
include/sound/ump_msg.h:196:13: error: duplicate member 'reserved'
196 | u32 reserved:8;
| ^~~~~~~~
include/sound/ump_msg.h:197:13: error: duplicate member 'program'
197 | u32 program:8;
| ^~~~~~~
include/sound/ump_msg.h:198:13: error: duplicate member 'channel'
198 | u32 channel:4;
| ^~~~~~~
include/sound/ump_msg.h:199:13: error: duplicate member 'status'
199 | u32 status:4;
| ^~~~~~
include/sound/ump_msg.h:200:13: error: duplicate member 'group'
200 | u32 group:4;
| ^~~~~
include/sound/ump_msg.h:201:13: error: duplicate member 'type'
201 | u32 type:4;
| ^~~~
Caused by commit
0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
I have applied the following fix patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 24 May 2023 13:39:38 +1000
Subject: [PATCH] fix up for "ALSA: ump: Add legacy raw MIDI support"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/sound/ump_msg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sound/ump_msg.h b/include/sound/ump_msg.h
index c76c39944a5f..a594ef951b54 100644
--- a/include/sound/ump_msg.h
+++ b/include/sound/ump_msg.h
@@ -192,13 +192,13 @@ struct snd_ump_midi1_msg_program {
u32 program:8;
u32 reserved:8;
#else
-#endif
u32 reserved:8;
u32 program:8;
u32 channel:4;
u32 status:4;
u32 group:4;
u32 type:4;
+#endif
} __packed;
/* MIDI 1.0 Channel Pressure (32bit) */
--
2.39.2
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2023-05-24 3:54 Stephen Rothwell
@ 2023-05-24 7:14 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2023-05-24 7:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Takashi Iwai, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, 24 May 2023 05:54:48 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> In file included from sound/core/seq/seq_ump_convert.c:11:
> include/sound/ump_msg.h:196:13: error: duplicate member 'reserved'
> 196 | u32 reserved:8;
> | ^~~~~~~~
> include/sound/ump_msg.h:197:13: error: duplicate member 'program'
> 197 | u32 program:8;
> | ^~~~~~~
> include/sound/ump_msg.h:198:13: error: duplicate member 'channel'
> 198 | u32 channel:4;
> | ^~~~~~~
> include/sound/ump_msg.h:199:13: error: duplicate member 'status'
> 199 | u32 status:4;
> | ^~~~~~
> include/sound/ump_msg.h:200:13: error: duplicate member 'group'
> 200 | u32 group:4;
> | ^~~~~
> include/sound/ump_msg.h:201:13: error: duplicate member 'type'
> 201 | u32 type:4;
> | ^~~~
>
> Caused by commit
>
> 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
>
> I have applied the following fix patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 24 May 2023 13:39:38 +1000
> Subject: [PATCH] fix up for "ALSA: ump: Add legacy raw MIDI support"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Thanks! This was a late change and I have skipped testing big-endian
since then, as it seems...
I queued up your fix patch.
Takashi
> ---
> include/sound/ump_msg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/sound/ump_msg.h b/include/sound/ump_msg.h
> index c76c39944a5f..a594ef951b54 100644
> --- a/include/sound/ump_msg.h
> +++ b/include/sound/ump_msg.h
> @@ -192,13 +192,13 @@ struct snd_ump_midi1_msg_program {
> u32 program:8;
> u32 reserved:8;
> #else
> -#endif
> u32 reserved:8;
> u32 program:8;
> u32 channel:4;
> u32 status:4;
> u32 group:4;
> u32 type:4;
> +#endif
> } __packed;
>
> /* MIDI 1.0 Channel Pressure (32bit) */
> --
> 2.39.2
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2022-07-15 12:44 Stephen Rothwell
2022-07-15 14:41 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2022-07-15 12:44 UTC (permalink / raw)
To: Takashi Iwai
Cc: Andy Shevchenko, Linux Kernel Mailing List,
Linux Next Mailing List, Stefan Binding, Vitaly Rodionov
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (powerpc
allyesconfig) failed like this:
sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
693 | status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
| ^~
Caused by commit
d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")
along with commit
eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")
I have reverted commit d60b05b4c780 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2022-07-15 12:44 Stephen Rothwell
@ 2022-07-15 14:41 ` Takashi Iwai
2022-07-15 19:09 ` Andy Shevchenko
0 siblings, 1 reply; 32+ messages in thread
From: Takashi Iwai @ 2022-07-15 14:41 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Takashi Iwai, Andy Shevchenko, Linux Kernel Mailing List,
Linux Next Mailing List, Stefan Binding, Vitaly Rodionov
On Fri, 15 Jul 2022 14:44:43 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
> sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
> 693 | status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
> | ^~
>
> Caused by commit
>
> d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")
>
> along with commit
>
> eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")
>
> I have reverted commit d60b05b4c780 for today.
Thanks. Now I reverted the commit on for-next branch as a workaround,
too.
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2022-07-15 14:41 ` Takashi Iwai
@ 2022-07-15 19:09 ` Andy Shevchenko
0 siblings, 0 replies; 32+ messages in thread
From: Andy Shevchenko @ 2022-07-15 19:09 UTC (permalink / raw)
To: Takashi Iwai
Cc: Stephen Rothwell, Andy Shevchenko, Linux Kernel Mailing List,
Linux Next Mailing List, Stefan Binding, Vitaly Rodionov
On Fri, Jul 15, 2022 at 5:39 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Fri, 15 Jul 2022 14:44:43 +0200,
> Stephen Rothwell wrote:
> >
> > Hi all,
> >
> > After merging the sound tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
> > sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
> > 693 | status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
> > | ^~
> >
> > Caused by commit
> >
> > d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")
> >
> > along with commit
> >
> > eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")
> >
> > I have reverted commit d60b05b4c780 for today.
>
> Thanks. Now I reverted the commit on for-next branch as a workaround,
> too.
Thanks! OTOH it means it's working well :-)
Nevertheless, I have prepared a series to deduplicate this _SUB code
and I think the ACPI would stay as a compile dependency because of
that change anyway.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2021-10-18 0:38 Stephen Rothwell
2021-10-18 6:35 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2021-10-18 0:38 UTC (permalink / raw)
To: Takashi Iwai
Cc: Takashi Sakamoto, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from <command-line>:32:
./usr/include/sound/firewire.h:71:16: error: C++ style comments are not allowed in ISO C90
71 | __u32 count; // The number of changes.
| ^
./usr/include/sound/firewire.h:71:16: note: (this will be reported only once per input file)
Caused by commit
634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
I have used the sound tree from next-20211015 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2021-10-18 0:38 Stephen Rothwell
@ 2021-10-18 6:35 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2021-10-18 6:35 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Takashi Sakamoto, Linux Kernel Mailing List, Linux Next Mailing List
On Mon, 18 Oct 2021 02:38:12 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from <command-line>:32:
> ./usr/include/sound/firewire.h:71:16: error: C++ style comments are not allowed in ISO C90
> 71 | __u32 count; // The number of changes.
> | ^
> ./usr/include/sound/firewire.h:71:16: note: (this will be reported only once per input file)
>
> Caused by commit
>
> 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model")
>
> I have used the sound tree from next-20211015 for today.
I'll submit and queue the fix. Thanks!
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2020-07-17 3:01 Stephen Rothwell
2020-07-17 5:33 ` Christoph Hellwig
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2020-07-17 3:01 UTC (permalink / raw)
To: Takashi Iwai, Christoph Hellwig
Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/core/pcm_memory.c: In function 'do_alloc_pages':
sound/core/pcm_memory.c:47:7: error: implicit declaration of function 'dma_is_direct'; did you mean 'd_is_dir'? [-Werror=implicit-function-declaration]
47 | !dma_is_direct(get_dma_ops(dev))) {
| ^~~~~~~~~~~~~
| d_is_dir
Caused by commit
3ad796cbc36a ("ALSA: pcm: Use SG-buffer only when direct DMA is available")
interacting with commit
d3fa60d7bfdc ("dma-mapping: move the remaining DMA API calls out of line")
from the dma-mapping tree.
I am not sure of the best fix here, so I just added this hack to make
it build for now. Suggestions welcome.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 17 Jul 2020 12:57:38 +1000
Subject: [PATCH] merge fix for dma_is_direct() removal
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
sound/core/pcm_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
index 795af1b88051..89480f12086a 100644
--- a/sound/core/pcm_memory.c
+++ b/sound/core/pcm_memory.c
@@ -44,7 +44,7 @@ static int do_alloc_pages(struct snd_card *card, int type, struct device *dev,
#ifdef CONFIG_SND_DMA_SGBUF
if ((type == SNDRV_DMA_TYPE_DEV_SG || type == SNDRV_DMA_TYPE_DEV_UC_SG) &&
- !dma_is_direct(get_dma_ops(dev))) {
+ 1 /* !dma_is_direct(get_dma_ops(dev)) */) {
/* mutate to continuous page allocation */
dev_dbg(dev, "Use continuous page allocator\n");
if (type == SNDRV_DMA_TYPE_DEV_SG)
--
2.27.0
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2020-07-17 3:01 Stephen Rothwell
@ 2020-07-17 5:33 ` Christoph Hellwig
2020-07-17 6:34 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Christoph Hellwig @ 2020-07-17 5:33 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Takashi Iwai, Christoph Hellwig, Linux Next Mailing List,
Linux Kernel Mailing List
On Fri, Jul 17, 2020 at 01:01:12PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
No, the sound commit needs to be reverted. Drivers has absolutely not
business poking into DMA layer internals.
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: linux-next: build failure after merge of the sound tree
2020-07-17 5:33 ` Christoph Hellwig
@ 2020-07-17 6:34 ` Takashi Iwai
2020-07-17 6:50 ` Christoph Hellwig
0 siblings, 1 reply; 32+ messages in thread
From: Takashi Iwai @ 2020-07-17 6:34 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On Fri, 17 Jul 2020 07:33:24 +0200,
Christoph Hellwig wrote:
>
> On Fri, Jul 17, 2020 at 01:01:12PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the sound tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
>
> No, the sound commit needs to be reverted. Drivers has absolutely not
> business poking into DMA layer internals.
OK, I'll drop that stuff again. It was the thing posted in the thread
of DMA regression with AMD SEV on 5.8-rc1. Meanwhile it was fixed in
the proper Kconfig dependency.
thanks,
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: linux-next: build failure after merge of the sound tree
2020-07-17 6:34 ` Takashi Iwai
@ 2020-07-17 6:50 ` Christoph Hellwig
2020-07-17 6:54 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Christoph Hellwig @ 2020-07-17 6:50 UTC (permalink / raw)
To: Takashi Iwai
Cc: Christoph Hellwig, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List
On Fri, Jul 17, 2020 at 08:34:47AM +0200, Takashi Iwai wrote:
> On Fri, 17 Jul 2020 07:33:24 +0200,
> Christoph Hellwig wrote:
> >
> > On Fri, Jul 17, 2020 at 01:01:12PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the sound tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> >
> > No, the sound commit needs to be reverted. Drivers has absolutely not
> > business poking into DMA layer internals.
>
> OK, I'll drop that stuff again. It was the thing posted in the thread
> of DMA regression with AMD SEV on 5.8-rc1. Meanwhile it was fixed in
> the proper Kconfig dependency.
We have other x86 changes that will not support just remapping stuff
ignoring the API in the pipe, so this will need to get sorted out. And
with that I mean sorted out properly instead of poking into undocumented
DMA API internals and coming to the wrong conclusions again..
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: linux-next: build failure after merge of the sound tree
2020-07-17 6:50 ` Christoph Hellwig
@ 2020-07-17 6:54 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2020-07-17 6:54 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Takashi Iwai, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List
On Fri, 17 Jul 2020 08:50:30 +0200,
Christoph Hellwig wrote:
>
> On Fri, Jul 17, 2020 at 08:34:47AM +0200, Takashi Iwai wrote:
> > On Fri, 17 Jul 2020 07:33:24 +0200,
> > Christoph Hellwig wrote:
> > >
> > > On Fri, Jul 17, 2020 at 01:01:12PM +1000, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > After merging the sound tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > >
> > > No, the sound commit needs to be reverted. Drivers has absolutely not
> > > business poking into DMA layer internals.
> >
> > OK, I'll drop that stuff again. It was the thing posted in the thread
> > of DMA regression with AMD SEV on 5.8-rc1. Meanwhile it was fixed in
> > the proper Kconfig dependency.
>
> We have other x86 changes that will not support just remapping stuff
> ignoring the API in the pipe, so this will need to get sorted out. And
> with that I mean sorted out properly instead of poking into undocumented
> DMA API internals and coming to the wrong conclusions again..
OK, when a proper API (or some kconfig) is ready for referring from
the driver side, let me know. I'd love to keep the SG-buffer support
as much as possible, since HD-audio stuff has been used for a very old
machine with a small RAM.
thanks,
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2019-08-09 2:54 Stephen Rothwell
2019-08-09 5:55 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2019-08-09 2:54 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read':
sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration]
v = readl(aligned_addr);
^~~~~
d_real
sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write':
sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
writel(v, aligned_addr);
^~~~~~
Caused by commit
19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
I have applied the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 9 Aug 2019 12:50:25 +1000
Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h
Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
sound/hda/hdac_bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c
index dc2523ef7d98..cd25e2b3f7f2 100644
--- a/sound/hda/hdac_bus.c
+++ b/sound/hda/hdac_bus.c
@@ -4,6 +4,7 @@
*/
#include <linux/init.h>
+#include <linux/io.h>
#include <linux/device.h>
#include <linux/module.h>
#include <linux/export.h>
--
2.20.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2019-08-09 2:54 Stephen Rothwell
@ 2019-08-09 5:55 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2019-08-09 5:55 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Mark Brown, Linux Next Mailing List, Linux Kernel Mailing List
On Fri, 09 Aug 2019 04:54:58 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read':
> sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration]
> v = readl(aligned_addr);
> ^~~~~
> d_real
> sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write':
> sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
> writel(v, aligned_addr);
> ^~~~~~
>
> Caused by commit
>
> 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
>
> I have applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 9 Aug 2019 12:50:25 +1000
> Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h
>
> Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> sound/hda/hdac_bus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c
> index dc2523ef7d98..cd25e2b3f7f2 100644
> --- a/sound/hda/hdac_bus.c
> +++ b/sound/hda/hdac_bus.c
> @@ -4,6 +4,7 @@
> */
>
> #include <linux/init.h>
> +#include <linux/io.h>
> #include <linux/device.h>
> #include <linux/module.h>
> #include <linux/export.h>
Thanks, it's obviously a right fix.
I applied it on top of topic/hda-bus-ops-cleanup branch branch.
Mark, feel free to pull it into yours again.
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2017-05-17 1:29 Stephen Rothwell
2017-05-17 5:30 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2017-05-17 1:29 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Takashi,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/linux/delay.h:21:0,
from sound/pcmcia/vx/vxp_ops.c:23:
sound/pcmcia/vx/vxp_ops.c: In function 'vxp_dma_read':
sound/pcmcia/vx/vxp_ops.c:406:43: error: '_chip' undeclared (first use in this function)
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
sound/pcmcia/vx/vxp_ops.c:406:43: note: each undeclared identifier is reported only once for each function it appears in
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_boost':
sound/pcmcia/vx/vxp_ops.c:470:43: error: '_chip' undeclared (first use in this function)
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
sound/pcmcia/vx/vxp_ops.c:470:31: note: in expansion of macro 'to_vxpocket'
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_level':
sound/pcmcia/vx/vxp_ops.c:512:43: error: '_chip' undeclared (first use in this function)
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
^
sound/pcmcia/vx/vxp_ops.c:512:31: note: in expansion of macro 'to_vxpocket'
struct snd_vxpocket *pchip = to_vxpocket(_chip);
^
Caused by commit
7c46696e8fef ("ALSA: vxpocket: Use container_of()")
I have used the sound tree from next-20170516 for today.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2017-05-17 1:29 Stephen Rothwell
@ 2017-05-17 5:30 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2017-05-17 5:30 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
On Wed, 17 May 2017 03:29:21 +0200,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/linux/delay.h:21:0,
> from sound/pcmcia/vx/vxp_ops.c:23:
> sound/pcmcia/vx/vxp_ops.c: In function 'vxp_dma_read':
> sound/pcmcia/vx/vxp_ops.c:406:43: error: '_chip' undeclared (first use in this function)
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
> const typeof( ((type *)0)->member ) *__mptr = (ptr); \
> ^
> sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> sound/pcmcia/vx/vxp_ops.c:406:43: note: each undeclared identifier is reported only once for each function it appears in
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
> const typeof( ((type *)0)->member ) *__mptr = (ptr); \
> ^
> sound/pcmcia/vx/vxp_ops.c:406:31: note: in expansion of macro 'to_vxpocket'
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_boost':
> sound/pcmcia/vx/vxp_ops.c:470:43: error: '_chip' undeclared (first use in this function)
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
> const typeof( ((type *)0)->member ) *__mptr = (ptr); \
> ^
> sound/pcmcia/vx/vxp_ops.c:470:31: note: in expansion of macro 'to_vxpocket'
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> sound/pcmcia/vx/vxp_ops.c: In function 'vx_set_mic_level':
> sound/pcmcia/vx/vxp_ops.c:512:43: error: '_chip' undeclared (first use in this function)
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
> include/linux/kernel.h:854:49: note: in definition of macro 'container_of'
> const typeof( ((type *)0)->member ) *__mptr = (ptr); \
> ^
> sound/pcmcia/vx/vxp_ops.c:512:31: note: in expansion of macro 'to_vxpocket'
> struct snd_vxpocket *pchip = to_vxpocket(_chip);
> ^
>
> Caused by commit
>
> 7c46696e8fef ("ALSA: vxpocket: Use container_of()")
>
> I have used the sound tree from next-20170516 for today.
My bad, I applied the wrong version of the patch.
Now fixed and pushed out.
thanks,
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2011-09-23 2:49 Stephen Rothwell
2011-09-23 5:21 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2011-09-23 2:49 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build ()
failed like this:
sound/pci/fm801.c: In function 'snd_fm801_tea575x_get_pins':
sound/pci/fm801.c:759:2: error: expected ',' or ';' before 'return'
sound/pci/fm801.c:757:32: warning: unused variable 'gpio'
sound/pci/fm801.c:756:17: warning: unused variable 'reg'
sound/pci/fm801.c:761:1: warning: no return statement in function returning non-void
sound/pci/fm801.c: In function 'snd_fm801_create':
sound/pci/fm801.c:1251:5: error: implicit declaration of function 'get_tea57x_gpio'
sound/pci/fm801.c:1251:5: error: invalid type argument of '->' (have 'int')
Caused by commit c51a94adef4c ("ALSA: fm801 - Clean up redundant reference to snd_fm801_tea575x_gpios[]").
I have used the sound tree from next-20110922 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2011-09-23 2:49 Stephen Rothwell
@ 2011-09-23 5:21 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2011-09-23 5:21 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
At Fri, 23 Sep 2011 12:49:34 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build ()
> failed like this:
>
> sound/pci/fm801.c: In function 'snd_fm801_tea575x_get_pins':
> sound/pci/fm801.c:759:2: error: expected ',' or ';' before 'return'
> sound/pci/fm801.c:757:32: warning: unused variable 'gpio'
> sound/pci/fm801.c:756:17: warning: unused variable 'reg'
> sound/pci/fm801.c:761:1: warning: no return statement in function returning non-void
> sound/pci/fm801.c: In function 'snd_fm801_create':
> sound/pci/fm801.c:1251:5: error: implicit declaration of function 'get_tea57x_gpio'
> sound/pci/fm801.c:1251:5: error: invalid type argument of '->' (have 'int')
>
> Caused by commit c51a94adef4c ("ALSA: fm801 - Clean up redundant reference to snd_fm801_tea575x_gpios[]").
>
> I have used the sound tree from next-20110922 for today.
My bad, fixed now.
thanks,
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2011-05-19 1:15 Stephen Rothwell
0 siblings, 0 replies; 32+ messages in thread
From: Stephen Rothwell @ 2011-05-19 1:15 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Ben Gardiner
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
sound/core/pcm_lib.c:333:40: error: macro "xrun_log" passed 3 arguments, but takes just 2
sound/core/pcm_lib.c: In function 'snd_pcm_update_hw_ptr0':
sound/core/pcm_lib.c:333: error: 'xrun_log' undeclared (first use in this function)
Caused by commit ec08b14483de ("ALSA: sound, core, pcm_lib: xrun_log: log
also in_interrupt"). This build has CONFIG_SND_PCM_XRUN_DEBUG unset.
Please, please, use grep or some search when making API changes.
I have used the sound tree from next-20110518 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* linux-next: build failure after merge of the sound tree
@ 2010-09-23 2:44 Stephen Rothwell
2010-09-23 6:04 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2010-09-23 2:44 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Mark Brown, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/soc/soc-cache.c: In function 'snd_soc_8_16_write':
sound/soc/soc-cache.c:207: error: 'struct snd_soc_codec' has no member named 'reg_cache_size'
Caused by commit 0077ca0b5c986477e33451b797b6e7dc92a8bbc0 ("ASoC: Fix
multi-componentism") which looks like it was fixing something that didn't
need fixing (or maybe fixed it incorrectly)? This commit is not in the
sound-asoc tree (but the commit it purports to be fixing is in both the
sound and sound-asoc trees) ...
I have used the version of the sound tree from next-20100921 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2010-09-23 2:44 Stephen Rothwell
@ 2010-09-23 6:04 ` Takashi Iwai
2010-09-23 8:39 ` Mark Brown
0 siblings, 1 reply; 32+ messages in thread
From: Takashi Iwai @ 2010-09-23 6:04 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Mark Brown, Liam Girdwood
At Thu, 23 Sep 2010 12:44:45 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/soc-cache.c: In function 'snd_soc_8_16_write':
> sound/soc/soc-cache.c:207: error: 'struct snd_soc_codec' has no member named 'reg_cache_size'
>
> Caused by commit 0077ca0b5c986477e33451b797b6e7dc92a8bbc0 ("ASoC: Fix
> multi-componentism") which looks like it was fixing something that didn't
> need fixing (or maybe fixed it incorrectly)? This commit is not in the
> sound-asoc tree (but the commit it purports to be fixing is in both the
> sound and sound-asoc trees) ...
>
Ah, this was a quick fix for 2.6.36, but it needs to be reverted again
for 2.6.37. for-next branch contains 2.6.37 patches, thus it got
broken. I fixed now. Mark, could you pull topic/asoc branch on my tree?
Sorry for inconvenience.
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2010-09-23 6:04 ` Takashi Iwai
@ 2010-09-23 8:39 ` Mark Brown
0 siblings, 0 replies; 32+ messages in thread
From: Mark Brown @ 2010-09-23 8:39 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Stephen Rothwell, linux-next, linux-kernel, Liam Girdwood
On Thu, Sep 23, 2010 at 08:04:45AM +0200, Takashi Iwai wrote:
> Ah, this was a quick fix for 2.6.36, but it needs to be reverted again
> for 2.6.37. for-next branch contains 2.6.37 patches, thus it got
> broken. I fixed now. Mark, could you pull topic/asoc branch on my tree?
Will do, thanks.
^ permalink raw reply [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2010-06-01 2:30 Stephen Rothwell
2010-06-01 5:47 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2010-06-01 2:30 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Daniel Mack
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from drivers/usb/gadget/audio.c:37:
drivers/usb/gadget/f_audio.c:104: error: 'UAC_MUTE_CONTROL' undeclared here (not in a function)
drivers/usb/gadget/f_audio.c:113: error: 'UAC_VOLUME_CONTROL' undeclared here (not in a function)
Presumably caused by commit 65f25da44b51f55e3a74301c25f29263be2bf1ba
("ALSA: usb-audio: unify constants from specification").
I have used the version of the sound tree from next-20100531 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2010-06-01 2:30 Stephen Rothwell
@ 2010-06-01 5:47 ` Takashi Iwai
0 siblings, 0 replies; 32+ messages in thread
From: Takashi Iwai @ 2010-06-01 5:47 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Daniel Mack
At Tue, 1 Jun 2010 12:30:11 +1000,
Stephen Rothwell wrote:
>
> [1 <text/plain; US-ASCII (quoted-printable)>]
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from drivers/usb/gadget/audio.c:37:
> drivers/usb/gadget/f_audio.c:104: error: 'UAC_MUTE_CONTROL' undeclared here (not in a function)
> drivers/usb/gadget/f_audio.c:113: error: 'UAC_VOLUME_CONTROL' undeclared here (not in a function)
>
> Presumably caused by commit 65f25da44b51f55e3a74301c25f29263be2bf1ba
> ("ALSA: usb-audio: unify constants from specification").
>
> I have used the version of the sound tree from next-20100531 for today.
Oops, I forgot to run the build test of the whole tree...
Fixed it now like below.
thanks,
Takashi
---
>From f07ff97b012ff9485618faeadcc9b1e5f72ceefa Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 1 Jun 2010 07:42:03 +0200
Subject: [PATCH] usb/gadget: Replace the old USB audio FU definitions in f_audio.c
The USB audio FU definitions were renewed by the commit
65f25da44b51f55e3a74301c25f29263be2bf1ba
ALSA: usb-audio: unify constants from specification
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/usb/gadget/f_audio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/f_audio.c b/drivers/usb/gadget/f_audio.c
index 43bf445..b91115f 100644
--- a/drivers/usb/gadget/f_audio.c
+++ b/drivers/usb/gadget/f_audio.c
@@ -101,7 +101,7 @@ static struct uac_feature_unit_descriptor_0 feature_unit_desc = {
static struct usb_audio_control mute_control = {
.list = LIST_HEAD_INIT(mute_control.list),
.name = "Mute Control",
- .type = UAC_MUTE_CONTROL,
+ .type = UAC_FU_MUTE,
/* Todo: add real Mute control code */
.set = generic_set_cmd,
.get = generic_get_cmd,
@@ -110,7 +110,7 @@ static struct usb_audio_control mute_control = {
static struct usb_audio_control volume_control = {
.list = LIST_HEAD_INIT(volume_control.list),
.name = "Volume Control",
- .type = UAC_VOLUME_CONTROL,
+ .type = UAC_FU_VOLUME,
/* Todo: add real Volume control code */
.set = generic_set_cmd,
.get = generic_get_cmd,
--
1.7.0.3
^ permalink raw reply related [flat|nested] 32+ messages in thread
* linux-next: build failure after merge of the sound tree
@ 2010-04-07 3:39 Stephen Rothwell
2010-04-07 6:06 ` Takashi Iwai
0 siblings, 1 reply; 32+ messages in thread
From: Stephen Rothwell @ 2010-04-07 3:39 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Risto Suominen
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
sound/ppc/tumbler.c: In function 'tumbler_find_device':
sound/ppc/tumbler.c:1143: error: implicit declaration of function 'machine_is_compatible'
Caused by commit 819ef70b135ba66cd1659c913255686bf931e3d4 ("ALSA:
powermac - Reverse HP detection on G4 DA"). machine_is_compatible was
renamed to of_machine_is_compatible by commit
71a157e8edca55198e808f8561dd49017a54ee34 ("of: add 'of_' prefix to
machine_is_compatible()") in Linus' tree since Feb 26, 2010 (and is in
v2.6.34-rc1).
I have used the version of the sound tree from next-20100401 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: linux-next: build failure after merge of the sound tree
2010-04-07 3:39 Stephen Rothwell
@ 2010-04-07 6:06 ` Takashi Iwai
2010-04-07 7:16 ` Stephen Rothwell
0 siblings, 1 reply; 32+ messages in thread
From: Takashi Iwai @ 2010-04-07 6:06 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Risto Suominen
At Wed, 7 Apr 2010 13:39:19 +1000,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> sound/ppc/tumbler.c: In function 'tumbler_find_device':
> sound/ppc/tumbler.c:1143: error: implicit declaration of function 'machine_is_compatible'
>
> Caused by commit 819ef70b135ba66cd1659c913255686bf931e3d4 ("ALSA:
> powermac - Reverse HP detection on G4 DA"). machine_is_compatible was
> renamed to of_machine_is_compatible by commit
> 71a157e8edca55198e808f8561dd49017a54ee34 ("of: add 'of_' prefix to
> machine_is_compatible()") in Linus' tree since Feb 26, 2010 (and is in
> v2.6.34-rc1).
>
> I have used the version of the sound tree from next-20100401 for today.
Fixed now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 32+ messages in thread
end of thread, other threads:[~2023-08-18 11:48 UTC | newest]
Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-24 3:03 linux-next: build failure after merge of the sound tree Stephen Rothwell
2010-06-24 6:11 ` Takashi Iwai
2010-06-28 16:33 ` Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 3:12 Stephen Rothwell
2023-08-18 11:47 ` Takashi Iwai
2023-05-24 3:54 Stephen Rothwell
2023-05-24 7:14 ` Takashi Iwai
2022-07-15 12:44 Stephen Rothwell
2022-07-15 14:41 ` Takashi Iwai
2022-07-15 19:09 ` Andy Shevchenko
2021-10-18 0:38 Stephen Rothwell
2021-10-18 6:35 ` Takashi Iwai
2020-07-17 3:01 Stephen Rothwell
2020-07-17 5:33 ` Christoph Hellwig
2020-07-17 6:34 ` Takashi Iwai
2020-07-17 6:50 ` Christoph Hellwig
2020-07-17 6:54 ` Takashi Iwai
2019-08-09 2:54 Stephen Rothwell
2019-08-09 5:55 ` Takashi Iwai
2017-05-17 1:29 Stephen Rothwell
2017-05-17 5:30 ` Takashi Iwai
2011-09-23 2:49 Stephen Rothwell
2011-09-23 5:21 ` Takashi Iwai
2011-05-19 1:15 Stephen Rothwell
2010-09-23 2:44 Stephen Rothwell
2010-09-23 6:04 ` Takashi Iwai
2010-09-23 8:39 ` Mark Brown
2010-06-01 2:30 Stephen Rothwell
2010-06-01 5:47 ` Takashi Iwai
2010-04-07 3:39 Stephen Rothwell
2010-04-07 6:06 ` Takashi Iwai
2010-04-07 7:16 ` Stephen Rothwell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.