From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35785 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWJW6-00057H-5v for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:33:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWJW4-0000aW-VP for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:33:38 -0400 Received: from verein.lst.de ([213.95.11.210]:51254) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWJW4-0000aP-Jm for qemu-devel@nongnu.org; Tue, 06 Jul 2010 21:33:36 -0400 Date: Wed, 7 Jul 2010 03:33:35 +0200 From: Christoph Hellwig Message-ID: <20100707013335.GC3073@lst.de> References: <1278419869-26126-1-git-send-email-armbru@redhat.com> <1278419869-26126-4-git-send-email-armbru@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278419869-26126-4-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] Re: [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com On Tue, Jul 06, 2010 at 02:37:44PM +0200, Markus Armbruster wrote: > Disks without media make no sense. For SCSI, a Linux guest kernel > complains during boot. I didn't try other combinations. > > scsi-generic doesn't need the additional check, because it already > requires bdrv_is_sg(), which fails without media. Looks good, Reviewed-by: Christoph Hellwig