From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] 83xx: add support for ve8313 board
Date: Wed, 07 Jul 2010 11:11:24 +0200 [thread overview]
Message-ID: <20100707091124.F292B160696@gemini.denx.de> (raw)
In-Reply-To: <4C343AE3.7060804@denx.de>
Dear Heiko Schocher,
In message <4C343AE3.7060804@denx.de> you wrote:
>
> >> +#ifdef CONFIG_TSEC1
> >> +#define CONFIG_HAS_ETH0
> >> +#define CONFIG_TSEC1_NAME "TSEC0"
> >
> > Oops? This is TSEC1, so why do you name it "TSEC0" ?
>
> Because this is so in all other board configs I looked.
>
> Kim? Can you comment this?
> (I think it is because to be in sync with "eth0" ...)
That is not a good reason to confuse the users. TSEC0 and TSEC1 are
different interfaces, and to bend names is definitely a bad idea.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The trouble with our times is that the future is not what it used to
be. - Paul Valery
next prev parent reply other threads:[~2010-07-07 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 10:23 [U-Boot] 83xx: add support for ve8313 board Heiko Schocher
2010-07-06 23:24 ` Kim Phillips
2010-07-07 4:09 ` Heiko Schocher
2010-07-07 4:28 ` [U-Boot] [PATCH v2] " Heiko Schocher
2010-07-07 6:23 ` Stefan Roese
2010-07-07 6:37 ` Heiko Schocher
2010-07-07 7:26 ` Wolfgang Denk
2010-07-07 8:29 ` Heiko Schocher
2010-07-07 9:11 ` Wolfgang Denk [this message]
2010-07-07 10:26 ` [U-Boot] [PATCH v3] " Heiko Schocher
2010-07-09 21:15 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707091124.F292B160696@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.