From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/agp/i915: trim stolen space to 32M
Date: Thu, 8 Jul 2010 09:52:14 -0700
Message-ID: <20100708095214.02953e43@virtuousgeek.org>
References: <20100708092246.66f81e97@virtuousgeek.org>
	<201007081737.10942.simon.farnsworth@onelan.com>
	<89k77n$oab77c@fmsmga001.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com
	[67.222.39.38])
	by gabe.freedesktop.org (Postfix) with SMTP id 334769EBCD
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  8 Jul 2010 09:52:25 -0700 (PDT)
In-Reply-To: <89k77n$oab77c@fmsmga001.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, t.artem@mailcity.com
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 08 Jul 2010 17:42:19 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Thu, 8 Jul 2010 17:37:10 +0100, Simon Farnsworth <simon.farnsworth@onelan.com> wrote:
> > On Thursday 8 July 2010, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > Some BIOSes will claim a large chunk of stolen space.  Unless we
> > > reclaim it, our aperture for remapping buffer objects will be
> > > constrained.  So clamp the stolen space to 32M and ignore the rest.
> > > 
> > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15469 among others.
> > > 
> > > Adding the ignored stolen memory back into the general pool using the
> > > memory hotplug code is left as an exercise for the reader.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > FWIW, given how simple the code actually is:
> > Reviewed-by: Simon Farnsworth <simon.farnsworth@onelan.com>
> 
> Heh, you were meant to say:
> 
> "What? Export a magic parameter from intel-gtt.c to indicate how much
> space to remove from the aperture guestimate, but not replace the *broken*
> code in i915_dma.c with an interface from intel-gtt.c to query and control
> the populated GTT more precisely?"

Yeah, that's what this patch does.  It'll all be killed by Daniel's AGP
rework though!

-- 
Jesse Barnes, Intel Open Source Technology Center