All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 08/18] vnc: tight add PNG encoding
Date: Thu, 8 Jul 2010 14:19:01 +0100	[thread overview]
Message-ID: <20100708131901.GH32528@redhat.com> (raw)
In-Reply-To: <AANLkTilOT-gRWrHpiXBHGK3PGWoOoNsL2h70wikJZBcr@mail.gmail.com>

On Thu, Jul 08, 2010 at 03:10:31PM +0200, Corentin Chary wrote:
> On Thu, Jul 8, 2010 at 11:48 AM, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Wed, Jul 07, 2010 at 08:57:56PM +0200, Corentin Chary wrote:
> >> Introduce a new encoding: VNC_ENCODING_TIGHT_PNG [1] (-269) with a new
> >> tight filter VNC_TIGHT_PNG (0x0A). When the client tells it supports the Tight PNG
> >> encoding, the server will use tight, but will always send encoding pixels using
> >> PNG instead of zlib. If the client also told it support JPEG, then the server can
> >> send JPEG, because PNG will only be used in the cases zlib was used in normal tight.
> >
> > I know that VNC_ENCODING_TIGHT_PNG / -260 is already allocated to
> > QEMU in the RFB specification. Who is the authority for allocating
> > tight filter numbers, and have they recorded/approved use of 0x0A
> > for this PNG capability ?
> >
> 
> Tight PNG should considered as a new encoding, not as a tight pseudo encoding.
> When using Tight PNG, the server will send rect updates with -260, not 7.

Why layer this into the rest of the Tight protocol decoding then ? What
benefit does it offer over a more straightforward standalone "PNG" encoding,
that was completely independant of any tight based encoding.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

  reply	other threads:[~2010-07-08 13:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 18:57 [Qemu-devel] [PATCH v2 00/18] [PATCH v2 00/18] VNC Updates for 0.13 Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 01/18] vnc: tight: add JPEG and gradient subencoding with smooth image detection Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 02/18] vnc: JPEG should be disabled if the client don't set tight quality Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 03/18] vnc: add lossy option Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 04/18] ui: move all ui components in ui/ Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 05/18] vnc: rename vnc-encoding-* vnc-enc-* Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 06/18] vnc: tight: don't forget do at the last color Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 07/18] vnc: tight: remove a memleak in send_jpeg_rect() Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 08/18] vnc: tight add PNG encoding Corentin Chary
2010-07-08  9:48   ` Daniel P. Berrange
2010-07-08 13:10     ` Corentin Chary
2010-07-08 13:19       ` Daniel P. Berrange [this message]
2010-07-08 13:35         ` Corentin Chary
2010-07-08 13:37           ` Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 09/18] vnc: tight: specific zlib level and filters for each compression level Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 10/18] vnc: tight: stop using qdict for palette stuff Corentin Chary
2010-07-07 18:57 ` [Qemu-devel] [PATCH v2 11/18] vnc: encapsulate encoding members Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 12/18] vnc: fix tight png memory leak Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 13/18] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 14/18] vnc: threaded VNC server Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 15/18] vnc: add missing lock for vnc_cursor_define() Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 16/18] vnc: tight: fix rgb_prepare_row Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 17/18] vnc: tight: split send_sub_rect Corentin Chary
2010-07-07 18:58 ` [Qemu-devel] [PATCH v2 18/18] vnc: better default values for VNC options Corentin Chary
2010-07-13 17:47 ` [Qemu-devel] [PATCH v2 00/18] [PATCH v2 00/18] VNC Updates for 0.13 Rick Vernam
2010-07-15 13:48   ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100708131901.GH32528@redhat.com \
    --to=berrange@redhat.com \
    --cc=agraf@suse.de \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=corentin.chary@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.