From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34 Date: Fri, 9 Jul 2010 04:56:30 +0200 Message-ID: <20100709025628.GK6405__31954.4406760999$1278657185$gmane$org@nowhere> References: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Linus Torvalds Cc: Jens Axboe , DRI , Linux SCSI List , Patrick McHardy , Network Development , Linux Wireless List , Linux Kernel Mailing List , Jesse Barnes , "David S. Miller" , "Rafael J. Wysocki" , Linux ACPI , Al Viro , Dave Airlie , Andrew Morton , Kernel Testers List , Shawn Starr , Linux PM List , Maciej Rutecki List-Id: dri-devel@lists.freedesktop.org On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote: > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki wrote: > > Bug-Entry =A0 =A0 =A0 : http://bugzilla.kernel.org/show_bug.cgi?id=3D16= 334 > > Subject =A0 =A0 =A0 =A0 : reiserfs locking (v2) > > Submitter =A0 =A0 =A0 : Sergey Senozhatsky > > Date =A0 =A0 =A0 =A0 =A0 =A0: 2010-07-02 9:34 (7 days old) > > Message-ID =A0 =A0 =A0: <20100702093451.GA3973@swordfish.minsk.epam.com> > > References =A0 =A0 =A0: http://marc.info/?l=3Dlinux-kernel&m=3D12780630= 6303590&w=3D2 > = > Frederic? Al? I assume this is some late fallout from the BKL removal > ages ago.. It's the old filldir-vs-mmap crud, but normally it should > be impossible to trigger because the inode for a directory should > never be mmap'able, so we should never have the same i_mutex lock used > for both mmap and for filldir protection. > = > We saw some of that oddity long ago, I wonder if it's lockdep being > confused about some inodes. I think it has been there from the beginning. At least it was there before the reiserfs bkl removal in .32. Indeed the readdir <-> unmap/release inversion problem can not happen. But Al said that can happen between write and release. (Although I don't see where write takes the inode mutex). He also highlighted the fact that reiserfs refcounting based on i_count was totally broken. He has a fix the whole in the vfs tree, in the for-next branch on commit 6c2bdaf089a3876226893fab00dd83596c465ad2 "Fix reiserfs_file_release()" No more uses of the i_mutex on release after that, nor i_count, but a priva= te openers refcount and a tailpack mutex per reiserfs inode. ---------------------------------------------------------------------------= --- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first --