From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34 Date: Fri, 9 Jul 2010 23:35:50 +0200 Message-ID: <201007092335.50486.rjw__16604.4665420943$1278711559$gmane$org@sisk.pl> References: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera> <20100709020440.GJ6405@nowhere> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100709020440.GJ6405@nowhere> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Frederic Weisbecker Cc: Jens Axboe , Shawn Starr , DRI , Linux SCSI List , Patrick McHardy , Network Development , Linux Wireless List , Linux Kernel Mailing List , Jesse Barnes , "David S. Miller" , Linux ACPI , Al Viro , Dave Airlie , Andrew Morton , Kernel Testers List , Linus Torvalds , Linux PM List , Maciej Rutecki List-Id: linux-pm@vger.kernel.org On Friday, July 09, 2010, Frederic Weisbecker wrote: > On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote: > > On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki wrote: > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284 > > > Subject : Hitting WARN_ON in hw_breakpoint code > > > Submitter : Paul Mackerras > > > Date : 2010-06-23 12:57 (16 days old) > > > Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com> > > > References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2 > > > > This has "I have a fix, will post it very soon." in the thread from > > Frederic, but I'm not seeing anything else. Frederic? > > > > Right. In fact it wasn't a regression. The per task breakpoint reservation > design was broken from the beginning and this warning has revealed the > problem. This only touched perf, and it did since perf support breakpoints. > Fortunately ptrace wasn't concerned by this problem, even not by side effects > of this. > > The fix is invasive as it's a rewrite of a (little) part of the breakpoint > reservation. And since the symptom is only a warning and also breakpoints > never released from the constraint table (just a counter, no memory leak), > the fix is headed for 2.6.36. > > It is ready in tip:/perf/core: > > http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commitdiff;h=45a73372efe4a63f44aa2e1125d4a777c2fdc8d8 > > I think this ticket can be safely closed. OK, closing. Rafael