From: Arnd Bergmann <arnd@arndb.de>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: sri@us.ibm.com, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next-2.6] macvtap: Return error when macvlan drops the packet
Date: Mon, 12 Jul 2010 12:44:04 +0200 [thread overview]
Message-ID: <201007121244.04499.arnd@arndb.de> (raw)
In-Reply-To: <1278924474.7719.14.camel@localhost.localdomain>
On Monday 12 July 2010, Shirley Ma wrote:
>
> Return err when macvlan dropps the packet.
Can you be more specific why you think this is the right idea?
As far as I can tell, this will return '1' to user space for a dropped
packet (NET_XMIT_DROP) or another positive return value.
While this might be nice for a user application to know, neither does
qemu check for this nor does it match the read(2) documentation.
I fear if we want congestion control to improve, we need to do it
differently.
Arnd
next prev parent reply other threads:[~2010-07-12 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 8:47 [PATCH net-next-2.6] macvtap: Return error when macvlan drops the packet Shirley Ma
2010-07-12 10:44 ` Arnd Bergmann [this message]
2010-07-13 16:42 ` Shirley Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007121244.04499.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=mashirle@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.