From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH V3 0/8] Cleancache: overview Date: Fri, 23 Jul 2010 10:04:40 -0400 Message-ID: <20100723140440.GA12423@infradead.org> References: <20100621231809.GA11111@ca-server1.us.oracle.com4C49468B.40307@vflare.org> <840b32ff-a303-468e-9d4e-30fc92f629f8@default> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ngupta@vflare.org, Christoph Hellwig , akpm@linux-foundation.org, Chris Mason , viro@zeniv.linux.org.uk, adilger@sun.com, tytso@mit.edu, mfasheh@suse.com, Joel Becker , matthew@wil.cx, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org, JBeulich@novell.com, Kurt Hackel , npiggin@suse.de, Dave Mccracken , riel@redhat.com, avi@redhat.com, Konrad Wilk To: Dan Magenheimer Return-path: In-Reply-To: <840b32ff-a303-468e-9d4e-30fc92f629f8@default> List-ID: On Fri, Jul 23, 2010 at 06:58:03AM -0700, Dan Magenheimer wrote: > CHRISTOPH AND ANDREW, if you disagree and your concerns have > not been resolved, please speak up. Anything that need modification of a normal non-shared fs is utterly broken and you'll get a clear NAK, so the propsal before is a good one. There's a couple more issues like the still weird prototypes, e.g. and i_ino might not be enoug to uniquely identify an inode on serveral filesystems that use 64-bit inode inode numbers on 32-bit systems. Also making the ops vector global is just a bad idea. There is nothing making this sort of caching inherently global. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760192Ab0GWOE5 (ORCPT ); Fri, 23 Jul 2010 10:04:57 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:42683 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760053Ab0GWOEw (ORCPT ); Fri, 23 Jul 2010 10:04:52 -0400 Date: Fri, 23 Jul 2010 10:04:40 -0400 From: Christoph Hellwig To: Dan Magenheimer Cc: ngupta@vflare.org, Christoph Hellwig , akpm@linux-foundation.org, Chris Mason , viro@zeniv.linux.org.uk, adilger@sun.com, tytso@mit.edu, mfasheh@suse.com, Joel Becker , matthew@wil.cx, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org, JBeulich@novell.com, Kurt Hackel , npiggin@suse.de, Dave Mccracken , riel@redhat.com, avi@redhat.com, Konrad Wilk Subject: Re: [PATCH V3 0/8] Cleancache: overview Message-ID: <20100723140440.GA12423@infradead.org> References: <20100621231809.GA11111@ca-server1.us.oracle.com4C49468B.40307@vflare.org> <840b32ff-a303-468e-9d4e-30fc92f629f8@default> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <840b32ff-a303-468e-9d4e-30fc92f629f8@default> User-Agent: Mutt/1.5.20 (2009-08-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 23, 2010 at 06:58:03AM -0700, Dan Magenheimer wrote: > CHRISTOPH AND ANDREW, if you disagree and your concerns have > not been resolved, please speak up. Anything that need modification of a normal non-shared fs is utterly broken and you'll get a clear NAK, so the propsal before is a good one. There's a couple more issues like the still weird prototypes, e.g. and i_ino might not be enoug to uniquely identify an inode on serveral filesystems that use 64-bit inode inode numbers on 32-bit systems. Also making the ops vector global is just a bad idea. There is nothing making this sort of caching inherently global. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 23 Jul 2010 10:04:40 -0400 Subject: [Ocfs2-devel] [PATCH V3 0/8] Cleancache: overview In-Reply-To: <840b32ff-a303-468e-9d4e-30fc92f629f8@default> References: <20100621231809.GA11111@ca-server1.us.oracle.com4C49468B.40307@vflare.org> <840b32ff-a303-468e-9d4e-30fc92f629f8@default> Message-ID: <20100723140440.GA12423@infradead.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Magenheimer Cc: ngupta@vflare.org, Christoph Hellwig , akpm@linux-foundation.org, Chris Mason , viro@zeniv.linux.org.uk, adilger@sun.com, tytso@mit.edu, mfasheh@suse.com, Joel Becker , matthew@wil.cx, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org, JBeulich@novell.com, Kurt Hackel , npiggin@suse.de, Dave Mccracken , riel@redhat.com, avi@redhat.com, Konrad Wilk On Fri, Jul 23, 2010 at 06:58:03AM -0700, Dan Magenheimer wrote: > CHRISTOPH AND ANDREW, if you disagree and your concerns have > not been resolved, please speak up. Anything that need modification of a normal non-shared fs is utterly broken and you'll get a clear NAK, so the propsal before is a good one. There's a couple more issues like the still weird prototypes, e.g. and i_ino might not be enoug to uniquely identify an inode on serveral filesystems that use 64-bit inode inode numbers on 32-bit systems. Also making the ops vector global is just a bad idea. There is nothing making this sort of caching inherently global.