All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@redhat.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	chrisw@redhat.com, ddutile@redhat.com, bjorn.helgaas@hp.com,
	eike-kernel@sf-tec.de
Subject: Re: [PATCH v2] pci: Allow read/write access to sysfs I/O port resources
Date: Fri, 23 Jul 2010 10:42:57 -0700	[thread overview]
Message-ID: <20100723174257.GZ2651@x200.localdomain> (raw)
In-Reply-To: <20100723092806.58ef884f@virtuousgeek.org>

* Jesse Barnes (jbarnes@virtuousgeek.org) wrote:
> On Fri, 23 Jul 2010 09:10:27 -0600
> Alex Williamson <alex.williamson@redhat.com> wrote:
> 
> > On Mon, 2010-07-19 at 09:45 -0600, Alex Williamson wrote:
> > > PCI sysfs resource files currently only allow mmap'ing.  On x86 this
> > > works fine for memory backed BARs, but doesn't work at all for I/O
> > > port backed BARs.  Add read/write to I/O port PCI sysfs resource
> > > files to allow userspace access to these device regions.
> > > 
> > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> > > ---
> > 
> > Any thoughts on this for -next?  Thanks,
> 
> Yeah, I like it.  Unless there are objections I'll pull it in.

Acked-by: Chris Wright <chrisw@redhat.com>

I think we may have some room for follow-on cleanups so consolidate the
ioport read/write functions w/ other HAVE_PCI_LEGACY bits...

thanks,
-chris

  reply	other threads:[~2010-07-23 17:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-19  3:15 [PATCH] pci: Allow read/write access to I/O port resources Alex Williamson
2010-07-19  5:56 ` Rolf Eike Beer
2010-07-19 15:45 ` [PATCH v2] pci: Allow read/write access to sysfs " Alex Williamson
2010-07-23 15:10   ` Alex Williamson
2010-07-23 16:28     ` Jesse Barnes
2010-07-23 17:42       ` Chris Wright [this message]
2010-07-30 16:36   ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100723174257.GZ2651@x200.localdomain \
    --to=chrisw@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=ddutile@redhat.com \
    --cc=eike-kernel@sf-tec.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.