From: Christoph Hellwig <hch@lst.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/irq] x86: Always use irq stacks
Date: Tue, 27 Jul 2010 14:13:13 +0200 [thread overview]
Message-ID: <20100727121313.GA19976@lst.de> (raw)
In-Reply-To: <1279131672.4190.18.camel@localhost>
Ingo, can you test this patch implementing Steve's suggestion?
Unfortunately I'm not able to reproduce the bug on my setup anymore.
---
From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] x86-32: align irq stacks properly
As suggested by Steven Rostedt we need to align the irq stacks on the
stack size, not just the page size to make them work for stack traces
with 8k stacks.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-tip/arch/x86/kernel/irq_32.c
===================================================================
--- linux-2.6-tip.orig/arch/x86/kernel/irq_32.c 2010-07-27 14:06:50.634494682 +0200
+++ linux-2.6-tip/arch/x86/kernel/irq_32.c 2010-07-27 14:06:58.031494680 +0200
@@ -55,7 +55,7 @@ static inline void print_stack_overflow(
union irq_ctx {
struct thread_info tinfo;
u32 stack[THREAD_SIZE/sizeof(u32)];
-} __attribute__((aligned(PAGE_SIZE)));
+} __attribute__((aligned(THREAD_SIZE)));
static DEFINE_PER_CPU(union irq_ctx *, hardirq_ctx);
static DEFINE_PER_CPU(union irq_ctx *, softirq_ctx);
next prev parent reply other threads:[~2010-07-27 12:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 12:15 [PATCH 1/2] x86: always use irq stacks Christoph Hellwig
2010-06-29 10:21 ` [tip:x86/irq] x86: Always " tip-bot for Christoph Hellwig
2010-06-30 7:44 ` Ingo Molnar
2010-06-30 7:52 ` Christoph Hellwig
2010-06-30 7:58 ` Ingo Molnar
2010-06-30 8:04 ` Ingo Molnar
2010-07-08 20:42 ` Ingo Molnar
2010-07-08 20:53 ` Christoph Hellwig
2010-07-14 15:12 ` Christoph Hellwig
2010-07-14 15:27 ` Thomas Gleixner
2010-07-14 15:47 ` Christoph Hellwig
2010-07-14 18:21 ` Steven Rostedt
2010-07-27 12:13 ` Christoph Hellwig [this message]
2010-07-27 16:29 ` H. Peter Anvin
2010-07-27 18:36 ` [tip:x86/irq] x86-32: Align IRQ stacks properly tip-bot for Christoph Hellwig
2010-07-23 14:15 ` [tip:x86/irq] x86: Always use irq stacks Steven Rostedt
2010-07-23 14:24 ` Steven Rostedt
2010-07-23 16:39 ` Christoph Hellwig
2010-07-14 19:02 ` David Miller
2010-09-03 15:00 ` Ingo Molnar
2010-09-06 18:53 ` Alexander van Heukelum
2010-09-07 4:06 ` [tip:x86/irq] x86, 32-bit: Align percpu area and irq stacks to THREAD_SIZE tip-bot for Alexander van Heukelum
2010-09-07 4:55 ` [tip:x86/irq] x86: Always use irq stacks Ingo Molnar
2010-09-07 8:21 ` Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727121313.GA19976@lst.de \
--to=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.