All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 4/6] *	Register platform interface
Date: Tue, 27 Jul 2010 08:22:15 -0700	[thread overview]
Message-ID: <20100727152215.GB6395@kroah.com> (raw)
In-Reply-To: <20100727081633.GC32084@core.coreip.homeip.net>

On Tue, Jul 27, 2010 at 01:16:33AM -0700, Dmitry Torokhov wrote:
> On Mon, Jul 26, 2010 at 03:49:42PM -0700, Greg KH wrote:
> > On Fri, Jul 23, 2010 at 09:43:17AM -0700, Dmitry Torokhov wrote:
> > > On Fri, Jul 23, 2010 at 04:38:59PM +0100, Alan Cox wrote:
> > > > > I am confused here... Are you having a separate SPI driver create a
> > > > > platform device and then you have mrstouch to bind to this
> > > > > intermediate platform device? Are you doing that so you can introduce
> > > > > I2C interface later? If so I think I prefer how adxl34x and ad7879
> > > > > drivers are structured - they are split into core and interface parts
> > > > > but do not require extra devices/drivers (see in my 'next' brnach).
> > > > 
> > > > There is no SPI interface to the device. It ended up in the kernel SPI
> > > > because old versions of the device firmware listed it in the firmware
> > > > tables as SPI and rather than doing the right thing (correcting the
> > > > type) the x86 code created an SPI device for it.
> > > > 
> > > > At a certain level it may be SPI, but it's all hidden behind the
> > > > firmware on the SCU and nothing to do with Linux SPI at all.
> > > > 
> > > 
> > > Ah, OK then.
> > > 
> > > So, what is the plan of action? Greg, are you going to apply the patches
> > > to staging and move over to input or shoudl I do that (apply Alan's
> > > patches to staging _in my tree_ and move over to drivers.input)?
> > 
> > I already have the driver in my staging-next tree, so I can apply these
> > 6 patches as well, and then move it to the drivers/input subdirectory if
> > you want.
> > 
> > Or I can leave it all in drivers/staging/ and then after 2.6.36-rc1
> > comes, you can move the driver into drivers/input/ subdir.
> > 
> 
> The 2nd one I think is the best.

Great.  I'll queue up these patches then.  Alan, when 2.6.36-rc1 is out,
ask Dmitry to move the driver into the input subdir and all should be
good.

thanks,

greg k-h

  reply	other threads:[~2010-07-27 15:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 13:51 [PATCH 0/6] Complete the mrst touchscreen tidy Alan Cox
2010-07-23 13:51 ` [PATCH 1/6] mrst_touchscreen: clean up input side Alan Cox
2010-07-27 18:18   ` [PATCH 1/6] Staging: " Greg KH
2010-08-25 14:46     ` Dmitry Torokhov
2010-07-23 13:52 ` [PATCH 2/6] Input: mrst - more fixes Alan Cox
2010-07-23 13:52 ` [PATCH 3/6] mrst-touchscreen: Fix use before initialize in mrst_touch [Fix bug 2561] Alan Cox
2010-07-27 18:17   ` Greg KH
2010-07-23 13:52 ` [PATCH 4/6] * Register platform interface Alan Cox
2010-07-23 16:07   ` Dmitry Torokhov
2010-07-23 15:38     ` Alan Cox
2010-07-23 16:43       ` Dmitry Torokhov
2010-07-26 22:49         ` Greg KH
2010-07-27  8:16           ` Dmitry Torokhov
2010-07-27 15:22             ` Greg KH [this message]
2010-07-23 13:52 ` [PATCH 5/6] fix channel allocation in the touch screen driver Alan Cox
2010-07-23 13:52 ` [PATCH 6/6] Simplify en/disable of interrupts for NEC Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100727152215.GB6395@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.