From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757600Ab0G2OTX (ORCPT ); Thu, 29 Jul 2010 10:19:23 -0400 Received: from xenotime.net ([72.52.115.56]:44002 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757369Ab0G2OTV (ORCPT ); Thu, 29 Jul 2010 10:19:21 -0400 Date: Thu, 29 Jul 2010 07:19:14 -0700 From: Randy Dunlap To: Nir Tzachar Cc: Michal Marek , trapdoor6@gmail.com, Sam Ravnborg , LKML , "Justin P. Mattock" , trivial@kernel.org Subject: Re: Small typo in kernel [current source from git] .config option Message-Id: <20100729071914.bf615447.rdunlap@xenotime.net> In-Reply-To: References: <20100727165549.GC26649@merkur.ravnborg.org> <4C500E41.40708@suse.cz> <4C504FBB.3020600@suse.cz> <20100728185505.GF29266@merkur.ravnborg.org> <4C51362E.5010009@suse.cz> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jul 2010 13:33:49 +0300 Nir Tzachar wrote: > On Thu, Jul 29, 2010 at 11:05 AM, Michal Marek wrote: > > On 29.7.2010 08:20, trapDoor wrote: > >> On Thu, Jul 29, 2010 at 6:04 AM, Nir Tzachar wrote: > >>> On Wed, Jul 28, 2010 at 9:55 PM, Sam Ravnborg wrote: > >>>> The capitilazing is the main reason why I have > >>>> not recommended nconfig to be default. > >>>> > >>>> And I doubt the shortcut letters are used that often. > >>>> One idea could be to drop the shortcut for the individual menus. > >>> > >>> I almost never use them and removing them will have the benefit of > >>> cleaning the code. > >> > >> Neither do I. And I don't know anyone who would find them very useful. > > > > I actually do. Unlike menuconfig, nconfig will jump to a menu item even > > if it is not currently visible in the screen. Useful if you know the > > option name but don't want to scroll down and look for it. But I would > > accept a patch to remove the shortcut if there is no better way of > > marking the shortcuts than the capital letters. > > > > Michal > > > > There is a middle ground here: keep the shortcuts, but give no visual > indication (either capitalization or coloring). How do you tell libmenue what the shortcut character is? Is that a different attribute/field/specifier? If so, how about just adding the shortcut key in parentheses [or square brackets] after its word or phrase? E.g.: Hardware Error Device [A] > What do you say? I actually like this, as I dislike the ugly > capitalization hack. It's not pretty and it can be confusing, but I would certainly prefer to have some indicator for the shortcuts. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***