All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: "Jasper St. Pierre" <jstpierre@mecheye.net>
Cc: <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	<avarab@gmail.com>, "Shawn O. Pearce" <spearce@spearce.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] Do not unquote + into ' ' in URLs
Date: Sat, 31 Jul 2010 23:33:38 +0200	[thread overview]
Message-ID: <201007312333.38471.trast@student.ethz.ch> (raw)
In-Reply-To: <AANLkTikY_ayRzdbQ2Qsf6wus+=yg99aTLDTahVXUw0eK@mail.gmail.com>

Jasper St. Pierre wrote:
> Hmm.. could we get a follow-up on this patch? It's annoying because it's both
> backwards and forwards incompatible: the %2b workaround doesn't work in
> older versions.

I was hoping for an Ack from someone who knows the whole HTTP
business, because I don't feel confident enough to say it won't break
anything there.

To be precise, if the client ever attempts to decode URLs with query
strings (for whatever reasons) then it would break.  Probably there
are no such URLs, but I don't know for sure.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2010-07-31 21:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 13:18 URL decoding changed semantics of + in URLs Thomas Rast
2010-07-23 13:21 ` Thomas Rast
2010-07-23 14:10 ` Ævar Arnfjörð Bjarmason
2010-07-23 14:25   ` Jasper St. Pierre
2010-07-23 21:23   ` [PATCH] Do not unquote + into ' ' " Thomas Rast
2010-07-23 22:20     ` Ævar Arnfjörð Bjarmason
2010-07-23 22:26     ` Junio C Hamano
2010-07-23 23:04       ` Thomas Rast
2010-07-24 14:49         ` [PATCH v2] " Thomas Rast
2010-07-31 21:18           ` Jasper St. Pierre
2010-07-31 21:33             ` Thomas Rast [this message]
2010-08-06 10:46               ` Ralf Ebert
2010-07-26 15:40 ` URL decoding changed semantics of + " Jeff King
2010-07-26 17:57   ` Ævar Arnfjörð Bjarmason
2010-07-26 18:22     ` Jasper St. Pierre
2010-07-26 18:30       ` Matthieu Moy
2010-07-26 18:35       ` Ævar Arnfjörð Bjarmason
2010-07-26 18:44         ` Jasper St. Pierre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007312333.38471.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jstpierre@mecheye.net \
    --cc=peff@peff.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.