From mboxrd@z Thu Jan 1 00:00:00 1970 From: Harald Welte Date: Sun, 8 Aug 2010 06:06:49 +0200 Subject: [U-Boot] [PATCH v3 2/4] mtdparts: show net size in mtdparts list In-Reply-To: <20100807200850.680BDB715A@gemini.denx.de> References: <1275494319-29010-1-git-send-email-bengardiner@nanometrics.ca> <1278366212-24023-3-git-send-email-bengardiner@nanometrics.ca> <20100807200850.680BDB715A@gemini.denx.de> Message-ID: <20100808040649.GI12062@prithivi.gnumonks.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On Sat, Aug 07, 2010 at 10:08:50PM +0200, Wolfgang Denk wrote: > > * update copyright of cmd_mtdparts.c > > That was a bad idea. We do not add change logs to files, because we > have the full history of changes in git. just to clearly understand your point: Your objection is against the > > + * Added net partition size output to mtdparts list command in the file itself, as it should be a changelog. Your objection is (I hope) not against the author claiming copyright in the source code file itself, right? Copyright claims are something that you can hardly deny any author in the work itself - particularly since the majority of distributions are made as tarballs that do not contain the full git history. While even in the US there is now no legal requirement anymore to have this copyright notice to claim copyright, it is still common practise and a good idea. I definitely can confirm this from the actual GPL enforcement work that I've been doing, where you have to substantiate the fact that you actually do have copyright... and when the source file contains such indication, it is pretty straight forward. If you'd have to explain the workings of a revision control system and how to extract this information first, it will be significantly more complex. Regards, Harald -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)