From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 9 Aug 2010 13:51:37 -0500 Subject: [U-Boot] [PATCH 4/4 v2] mtdparts: new add.e: add part skipping bad blocks In-Reply-To: References: <1275423827-5803-1-git-send-email-bengardiner@nanometrics.ca> <1275494319-29010-5-git-send-email-bengardiner@nanometrics.ca> <20100809132525.32b10c8b@schlenkerla.am.freescale.net> Message-ID: <20100809135137.43a66d90@schlenkerla.am.freescale.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 9 Aug 2010 14:39:20 -0400 Ben Gardiner wrote: > Hi Scott, > > On Mon, Aug 9, 2010 at 2:25 PM, Scott Wood wrote: > > On Wed, 2 Jun 2010 11:58:39 -0400 > > Ben Gardiner wrote: > > > >> This patch adds a new 'mtdparts add' variant: add.e (with a synomym add.i). > > > > Why multiple ways to say the same thing, in a new command with no > > legacy to be compatible with? > > Just mimicking the add syntax. > > > Even on the commands where .e and .i used to do something, that's now > > the default, and the suffix is unnecessary. ?So I don't see any need to > > mimic the syntax. > > Ok. No objection here. > > > What do "e" and "i" even stand for? ?It looks like they were "for > > compatibility with older units" even when first committed. > > I don't really know. Should I stick with 'add.e' or would you prefer > 'add.spread' 'add.skip' or something else? ".spread" is nice if it matches what the "mtdparts spread" command does to existing partitions, but ".skip" might make sense in other contexts that we want to be consistent with. For instance, we probably want to do something with the "nand erase" command to differentiate clearing space for a certain amount of data (e.g. $filesize) versus erasing a partition (where the bad blocks should already be included in the size). Since the consistency arguments mostly cancel out, I'd go with ".spread", since it's different from read/write/erase in that you're not quite skipping anything, but incorporating room for the bad blocks into the partition. -Scott