From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Tettamanti <kronos.it@gmail.com>
Subject: [DRM] BUG: sleeping function called from invalid context,
	drm_lastclose
Date: Wed, 11 Aug 2010 10:48:29 +0200
Message-ID: <20100811084828.GA5709__34745.0520996519$1281516595$gmane$org@nb-core2.darkstar.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.sourceforge.net>
Content-Disposition: inline
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=dri-devel>
List-Post: <mailto:dri-devel@lists.sourceforge.net>
List-Help: <mailto:dri-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=subscribe>
Errors-To: dri-devel-bounces@lists.sourceforge.net
To: Arnd Bergmann <arnd@arndb.de>
Cc: dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

Hi Arnd,
this commit:

commit 58374713c9dfb4d231f8c56cac089f6fbdedc2ec
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Sat Jul 10 23:51:39 2010 +0200

    drm: kill BKL from common code


moved the call to (inside drm_release) drm_lastclose inside dev->count_lock
spinlock.
drm_lastclose however takes dev->struct_mutex (now inside an atomic
context):

BUG: sleeping function called from invalid context at /home/kronos/src/linux-2.6.git/kernel/mutex.c:94
in_atomic(): 1, irqs_disabled(): 0, pid: 3331, name: Xorg
Pid: 3331, comm: Xorg Not tainted 2.6.35-06113-gf6cec0a #272
Call Trace:
 [<ffffffff8102770e>] __might_sleep+0xf8/0xfa
 [<ffffffff8127cf18>] mutex_lock+0x1f/0x3e
 [<ffffffffa052d1c1>] drm_lastclose+0x92/0x2ad [drm]
 [<ffffffffa052dbc7>] drm_release+0x5ca/0x60d [drm]
 [<ffffffff810b118f>] fput+0x130/0x1f7
 [<ffffffff810ae77d>] filp_close+0x63/0x6d
 [<ffffffff810ae82f>] sys_close+0xa8/0xe2
 [<ffffffff8100296b>] system_call_fastpath+0x16/0x1b


Luca

------------------------------------------------------------------------------
This SF.net email is sponsored by 

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev 
--