All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>, linux-next@vger.kernel.org
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	akpm <akpm@linux-foundation.org>
Subject: [PATCH -next] optprobes: fix kconfig depends/selects
Date: Thu, 12 Aug 2010 12:26:41 -0700	[thread overview]
Message-ID: <20100812122641.fe88e846.randy.dunlap@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle.com>

KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.

warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc:	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc:	"David S. Miller" <davem@davemloft.net>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
---
 arch/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20100810.orig/arch/Kconfig
+++ linux-next-20100810/arch/Kconfig
@@ -45,6 +45,8 @@ config OPTPROBES
 	def_bool y
 	depends on KPROBES && HAVE_OPTPROBES
 	depends on !PREEMPT
+	depends on DEBUG_KERNEL
+	select KALLSYMS
 	select KALLSYMS_ALL
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS

             reply	other threads:[~2010-08-12 19:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 19:26 Randy Dunlap [this message]
2010-08-17 14:55 ` [PATCH -next] optprobes: fix kconfig depends/selects Masami Hiramatsu
2010-08-17 15:03   ` Masami Hiramatsu
2010-09-12 10:49 ` Felipe Contreras
2010-09-12 18:34   ` Randy Dunlap
2010-09-12 18:41     ` Felipe Contreras
2010-09-12 18:46       ` Randy Dunlap
2010-09-13  1:06   ` Masami Hiramatsu
2010-09-13  7:15     ` Masami Hiramatsu
2010-09-13  9:41       ` Felipe Contreras
2010-09-13 10:14         ` Masami Hiramatsu
2010-09-13 11:11           ` Felipe Contreras
2010-09-13 10:25       ` [PATCH -next,-tip ] kprobes: Fix Kconfig dependency Masami Hiramatsu
2010-09-13 10:25         ` Masami Hiramatsu
2010-09-13 16:33         ` Randy Dunlap
2010-09-13 19:54         ` [tip:perf/urgent] " tip-bot for Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100812122641.fe88e846.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.