All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input: add ABS definitions for 16 pressure sensitve pads
Date: Thu, 12 Aug 2010 20:39:33 -0700	[thread overview]
Message-ID: <20100813033933.GE2661@core.coreip.homeip.net> (raw)
In-Reply-To: <1281195497-6957-1-git-send-email-daniel@caiaq.de>

Hi Daniel,

On Sat, Aug 07, 2010 at 05:38:17PM +0200, Daniel Mack wrote:
> Signed-off-by: Daniel Mack <daniel@caiaq.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  include/linux/input.h           |   19 ++++++++++++++++++-
>  include/linux/mod_devicetable.h |    2 +-
>  2 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/input.h b/include/linux/input.h
> index 896a922..b88d965 100644
> --- a/include/linux/input.h
> +++ b/include/linux/input.h
> @@ -709,13 +709,30 @@ struct input_absinfo {
>  #define ABS_MT_TRACKING_ID	0x39	/* Unique ID of initiated contact */
>  #define ABS_MT_PRESSURE		0x3a	/* Pressure on contact area */
>  
> +#define ABS_PAD0		0x40	/* pressure sensitive pads */
> +#define ABS_PAD1		0x41
> +#define ABS_PAD2		0x42
> +#define ABS_PAD3		0x43
> +#define ABS_PAD4		0x44
> +#define ABS_PAD5		0x45
> +#define ABS_PAD6		0x46
> +#define ABS_PAD7		0x47
> +#define ABS_PAD8		0x48
> +#define ABS_PAD9		0x49
> +#define ABS_PAD10		0x4a
> +#define ABS_PAD11		0x4b
> +#define ABS_PAD12		0x4c
> +#define ABS_PAD13		0x4d
> +#define ABS_PAD14		0x4e
> +#define ABS_PAD15		0x4f
> +

I do not think this is the direction I want to go. Even though the
default size of the input devices (thanks to your work) is half of what
it is used to be I do not think we should be assing such anonymous event
types. How about creating separate vent devices that would report
ABS_PRESSURE for these?  Obviously you need userspace to understand such
compound device, the same as with new ABS_PAD* types.

I guess we need to increase numer of available event devices from 32 to
something larger (dynamic dev_t?) first...

Thanks.

-- 
Dmitry

  reply	other threads:[~2010-08-13  3:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-07 15:38 Daniel Mack
2010-08-13  3:39 ` Dmitry Torokhov [this message]
2010-09-02  9:40   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100813033933.GE2661@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=daniel@caiaq.de \
    --cc=linux-input@vger.kernel.org \
    --subject='Re: [PATCH] input: add ABS definitions for 16 pressure sensitve pads' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.