From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH 06/15] reiserfs: replace barriers with explicit flush / FUA usage Date: Wed, 18 Aug 2010 09:21:00 -0400 Message-ID: <20100818132100.GN5854@think> References: <20100818093432.646633424@bombadil.infradead.org> <20100818093500.807689586@bombadil.infradead.org> <20100818131627.GB4680@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , tj@kernel.org, swhiteho@redhat.com, konishi.ryusuke@lab.ntt.co.jp, tytso@mit.edu, hirofumi@mail.parknet.co.jp, mfasheh@suse.com, joel.becker@oracle.com, hughd@google.com, linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:35570 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906Ab0HRNVj (ORCPT ); Wed, 18 Aug 2010 09:21:39 -0400 Content-Disposition: inline In-Reply-To: <20100818131627.GB4680@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Aug 18, 2010 at 03:16:27PM +0200, Jan Kara wrote: > On Wed 18-08-10 05:29:14, Christoph Hellwig wrote: > > Switch to the WRITE_FLUSH_FUA flag for log writes and remove the EOPNOTSUPP > > detection for barriers. Note that reiserfs had a fairly different code > > path for barriers before as it wa the only filesystem actually making use > > of them. The new code always uses the old non-barrier codepath and just > > sets the WRITE_FLUSH_FUA explicitly for the journal commits. > > > > Signed-off-by: Christoph Hellwig > This one looks good to me as well. > Acked-by: Jan Kara me too Acked-by: Chris Mason